Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue in code and add redirects #3964

Merged
merged 3 commits into from
May 4, 2023
Merged

Fixes issue in code and add redirects #3964

merged 3 commits into from
May 4, 2023

Conversation

hdhalter
Copy link
Contributor

@hdhalter hdhalter commented May 3, 2023

Description

A PM notified me that the code is wrong in this file. I also added a redirect, since the 1.0 version was coming up.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Heather Halter <[email protected]>
@hdhalter hdhalter self-assigned this May 3, 2023
@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 backport 2.7 PR: Backport label for 2.7 labels May 3, 2023
Signed-off-by: Heather Halter <[email protected]>
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After saying it out loud 5 times, "autoamtically" is beginning to grow on me. But I guess we'll do this by the book. Looks good.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

_api-reference/index-apis/create-index.md Outdated Show resolved Hide resolved
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
@hdhalter hdhalter merged commit 9e5b044 into main May 4, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit 9e5b044)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
hdhalter pushed a commit that referenced this pull request May 4, 2023
* fix redirects



* fix spelling



* Update _api-reference/index-apis/create-index.md




---------




(cherry picked from commit 9e5b044)

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: kolchfa-aws <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
* fix redirects

Signed-off-by: Heather Halter <[email protected]>

* fix spelling

Signed-off-by: Heather Halter <[email protected]>

* Update _api-reference/index-apis/create-index.md

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: Heather Halter <[email protected]>

---------

Signed-off-by: Heather Halter <[email protected]>
Signed-off-by: Heather Halter <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
@hdhalter hdhalter deleted the Fix-redirects branch March 28, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 backport 2.5 PR: Backport label for 2.5 backport 2.6 PR: Backport label for 2.6 backport 2.7 PR: Backport label for 2.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants