Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie-splitting setting example for SAML backend documentation #3949

Merged
merged 2 commits into from
May 3, 2023

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented May 3, 2023

Description

Fix the example for the cookie-splitting setting that adds a prefix name so that it indicates "saml" instead of "oidc".

Issues Resolved

Fixes #3947

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum cwillum added security 4 - Doc review PR: Doc review in progress backport 2.7 PR: Backport label for 2.7 labels May 3, 2023
@cwillum cwillum requested a review from hdhalter as a code owner May 3, 2023 00:44
@cwillum cwillum self-assigned this May 3, 2023
@cwillum cwillum merged commit 2d20f53 into main May 3, 2023
@cwillum cwillum removed the 4 - Doc review PR: Doc review in progress label May 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2023
…3949)

* fix#3947 cookie splitting fix

Signed-off-by: cwillum <[email protected]>

* fix#3947 cookie splitting fix

Signed-off-by: cwillum <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit 2d20f53)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@cwillum cwillum deleted the fix#3947-cookie-split-eg-fix branch May 3, 2023 17:06
cwillum pushed a commit that referenced this pull request May 3, 2023
…3949) (#3958)

* fix#3947 cookie splitting fix



* fix#3947 cookie splitting fix



---------


(cherry picked from commit 2d20f53)

Signed-off-by: cwillum <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…pensearch-project#3949)

* fix#3947 cookie splitting fix

Signed-off-by: cwillum <[email protected]>

* fix#3947 cookie splitting fix

Signed-off-by: cwillum <[email protected]>

---------

Signed-off-by: cwillum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.7 PR: Backport label for 2.7 security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cookie-splitting setting example in SAML backend documentation[DOC]
3 participants