Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Prepper documentation for the SNS to SQS fan out pattern in S3 #3915

Merged

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented May 2, 2023

Description

Some users have hit an issue using Data Prepper with an SNS/SQS fan out. This can be overcome and this documentation change conveys what a user needs to do for it.

Issues Resolved

N/A

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS
Copy link
Collaborator

Looking over this now.


To meet the scale of logs produced in S3, some users require multiple SQS queues for their logs. You can use the [Amazon Simple Notification Service](https://docs.aws.amazon.com/sns/latest/dg/welcome.html) (SNS) to route event notifications from S3 to an SQS [fanout pattern](https://docs.aws.amazon.com/sns/latest/dg/sns-common-scenarios.html). Using SNS, all S3 event notifications go directly to a single SNS topic, where you can subscribe to multiple SQS queues.

To make sure that Data Prepper can parse the event from the SNS topic directly, configure [raw message delivery](https://docs.aws.amazon.com/sns/latest/dg/sns-large-payload-raw-message-delivery.html) on the SNS to SQS subscription. If you want Data Prepper to ignore an SQS queue that sends notifications to your SNS topic, do not enable raw message delivery those queues.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want Data Prepper to ignore an SQS queue

I don't think this properly conveys the situation. Data Prepper isn't ignoring these SQS queues. They are not being used at all by Data Prepper. Also, the user can configure those other queues to use raw message delivery or not. It doesn't affect Data Prepper and Data Prepper doesn't affect them.

The point of my original wording was to help with the objection that setting raw message delivery will affect other consumers.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

"When raw message delivery is not enabled on an SQS queue, Data Prepper does not use that SQS queue."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if that really conveys what I'm trying to say here.

This is my original text:

The raw message delivery option is on the connection between SNS and SQS.
Thus, you can have some SQS queues which do not enable raw message delivery.
Using Data Prepper will not interfere with those queues.

Perhaps we can simply say:

Setting this option will not affect other SQS queues which are subscribed to that SNS topic.

@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress v2.8.0 v2.7.0 and removed v2.8.0 labels May 8, 2023
@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress labels May 9, 2023
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Approved with noted changes. Thanks!

_data-prepper/common-use-cases/s3-logs.md Outdated Show resolved Hide resolved
_data-prepper/common-use-cases/s3-logs.md Outdated Show resolved Hide resolved
@natebower natebower removed the 5 - Editorial review PR: Editorial review in progress label May 12, 2023
Naarcha-AWS and others added 2 commits May 15, 2023 12:55
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS added the backport 2.7 PR: Backport label for 2.7 label May 15, 2023
@Naarcha-AWS Naarcha-AWS merged commit a9a47ed into opensearch-project:main May 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 15, 2023
…3915)

* Adds documentation on how to use the SNS to SQS fan out with Data Prepper.

Signed-off-by: David Venable <[email protected]>

* Grammar edits.

* Update s3-logs.md

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: David Venable <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit a9a47ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS added a commit that referenced this pull request May 15, 2023
…3915) (#4082)

* Adds documentation on how to use the SNS to SQS fan out with Data Prepper.



* Grammar edits.

* Update s3-logs.md

* Update _data-prepper/common-use-cases/s3-logs.md




* Update _data-prepper/common-use-cases/s3-logs.md




---------





(cherry picked from commit a9a47ed)

Signed-off-by: David Venable <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…pensearch-project#3915)

* Adds documentation on how to use the SNS to SQS fan out with Data Prepper.

Signed-off-by: David Venable <[email protected]>

* Grammar edits.

* Update s3-logs.md

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

* Update _data-prepper/common-use-cases/s3-logs.md

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: David Venable <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
@dlvenable dlvenable deleted the data-prepper-s3-logs-fan-out branch July 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.7 PR: Backport label for 2.7 v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants