Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content updates for segrep - benchmarking and recommended settings #3836

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

ariamarble
Copy link
Contributor

@ariamarble ariamarble commented Apr 21, 2023

Description

Issues Resolved

fixes #7168

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: ariamarble <[email protected]>
@ariamarble ariamarble self-assigned this Apr 21, 2023
@ariamarble ariamarble added performance Documentation related to OpenSearch performance 4 - Doc review PR: Doc review in progress v2.7.0 Sev2 High-medium priority. Upcoming release or incorrect information. labels Apr 21, 2023
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please note that segment replication currently does not support `wait_for requests` in refresh API.
{: .warning }

For the best performance, we recommend enabling the following settings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. But is the recommendation for both settings?

ariamarble and others added 3 commits April 21, 2023 14:09
Signed-off-by: ariamarble <[email protected]>
Signed-off-by: ariamarble <[email protected]>
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: ariamarble <[email protected]>
@ariamarble ariamarble merged commit bed32c1 into main Apr 21, 2023
vagimeli pushed a commit that referenced this pull request Apr 25, 2023
…3836)

* Content updates for segrep

Signed-off-by: ariamarble <[email protected]>

* Apply suggestions from doc review

Co-authored-by: kolchfa-aws <[email protected]>

* doc review changes

Signed-off-by: ariamarble <[email protected]>

* small wording change

Signed-off-by: ariamarble <[email protected]>

* small change

Signed-off-by: ariamarble <[email protected]>

---------

Signed-off-by: ariamarble <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
vagimeli added a commit that referenced this pull request Apr 25, 2023
vagimeli pushed a commit that referenced this pull request May 4, 2023
…3836)

* Content updates for segrep

Signed-off-by: ariamarble <[email protected]>

* Apply suggestions from doc review

Co-authored-by: kolchfa-aws <[email protected]>

* doc review changes

Signed-off-by: ariamarble <[email protected]>

* small wording change

Signed-off-by: ariamarble <[email protected]>

* small change

Signed-off-by: ariamarble <[email protected]>

---------

Signed-off-by: ariamarble <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
vagimeli added a commit that referenced this pull request May 4, 2023
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this pull request Oct 31, 2023
…pensearch-project#3836)

* Content updates for segrep

Signed-off-by: ariamarble <[email protected]>

* Apply suggestions from doc review

Co-authored-by: kolchfa-aws <[email protected]>

* doc review changes

Signed-off-by: ariamarble <[email protected]>

* small wording change

Signed-off-by: ariamarble <[email protected]>

* small change

Signed-off-by: ariamarble <[email protected]>

---------

Signed-off-by: ariamarble <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
@hdhalter hdhalter deleted the segrepperfupdates branch March 28, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress performance Documentation related to OpenSearch performance Sev2 High-medium priority. Upcoming release or incorrect information. v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants