-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new zip for example SAML configuration files that reflect latest version #3665
Conversation
…version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files.
Signed-off-by: cwillum <[email protected]>
Since we can't view the contents of the zip file here in GitHub, I'm pasting the note I added to the image settings in the image: opensearchproject/opensearch:latest # replace "latest" with your preferred OpenSearch version number before launching in production: for example, 2.6.0. |
Signed-off-by: cwillum <[email protected]>
Signed-off-by: cwillum <[email protected]>
@opensearch-project/security I'm trying to resolve this issue with the SAML example zip file getting stale with each new version release. I've added steps to have users modify the image: opensearchproject/opensearch:latest # replace "latest" with your preferred OpenSearch version number before launching in production: for example, 2.6.0. Could you have a look at this edit and see if it looks and sounds accurate/makes sense. Thanks. |
Signed-off-by: cwillum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't recommend the tag latest
, instead lets use 2
. This will point to whatever the latest v2.X.X version of OpenSearch that has been released, this should ensure this client will always startup with modifying these instructions.
Signed-off-by: Naarcha-AWS <[email protected]>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 07c4019) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 07c4019) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 07c4019) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 07c4019) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 07c4019) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 07c4019) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 07c4019) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…version (#3665) (#4521) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * Apply suggestions from code review --------- (cherry picked from commit 07c4019) Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) (#4524) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * Apply suggestions from code review --------- (cherry picked from commit 07c4019) Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) (#4523) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * Apply suggestions from code review --------- (cherry picked from commit 07c4019) Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) (#4522) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * Apply suggestions from code review --------- (cherry picked from commit 07c4019) Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) (#4520) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * Apply suggestions from code review --------- (cherry picked from commit 07c4019) Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) (#4519) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * Apply suggestions from code review --------- (cherry picked from commit 07c4019) Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) (#4518) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * fix#618 saml example download * Apply suggestions from code review --------- (cherry picked from commit 07c4019) Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]>
…version (opensearch-project#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]>
…version (#3665) * Add new zip for example SAML configuration files that reflect latest version These changes add a new saml-example-custom.zip file containing `customize-docker-compose.yml`, `customize-config.yml`, and `customize-opensearch-dashboards.yml` files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files. * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * fix#618 saml example download Signed-off-by: cwillum <[email protected]> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: cwillum <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]>
Description
These changes add a new saml-example-custom.zip file containing
customize-docker-compose.yml
,customize-config.yml
, andcustomize-opensearch-dashboards.yml
files for use as the fully functioning SAML example. These changes also include edits to documentation so that steps accord with the new files.The
opensearch-dashboards.yml
file contains theserver.xsrf.allowlist
setting. For version 1.3 this setting must remainserver.xsrf.whitelist
to conform to code for that version. Therefore, I'll create a new PR for that download. This PR covers versions 2.x and should work for subsequent major releases.Issues Resolved
Fixes #618
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.