-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC]: Update Wizard naming convention #1808
Conversation
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
_dashboards/visbuilder.md
Outdated
|
||
<img src="{{site.url}}{{site.baseurl}}/images/enable-experimental-viz.png" alt="Enable experimental visualizations" width="550"> | ||
|
||
3. From the top menu, select **Visualize** **>** **Create visualization** **>** **Wizard**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should not be Wizard
anymore, it should VisBuilder
? @ashwin-pc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
_dashboards/visbuilder.md
Outdated
|
||
<img src="{{site.url}}{{site.baseurl}}/images/enable-experimental-viz.png" alt="Enable experimental visualizations" width="550"> | ||
|
||
3. From the top menu, select **Visualize** **>** **Create visualization** **>** **Wizard**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a couple of tweaks.
Signed-off-by: vagimeli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vagimeli Please see my comments and changes and let me know if you have any questions. Thanks!
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: vagimeli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change, otherwise LGTM
Signed-off-by: vagimeli <[email protected]>
Signed-off-by: vagimeli [email protected]
Description
Revised documentation to update naming convention for Wizard visualization type.
Issues Resolved
#1198
opensearch-project/OpenSearch-Dashboards#1157
opensearch-project/OpenSearch-Dashboards#2645 (comment)
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.