Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC:] New content and new page: Discover main page and multiple data sources #1711

Merged
merged 6 commits into from
Nov 2, 2022

Conversation

vagimeli
Copy link
Contributor

@vagimeli vagimeli commented Oct 26, 2022

Signed-off-by: vagimeli [email protected]

Description

Add new main page

Issues Resolved

#1710

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli vagimeli requested a review from a team as a code owner October 26, 2022 18:00
@vagimeli vagimeli self-assigned this Oct 26, 2022
@vagimeli vagimeli added the 4 - Doc review PR: Doc review in progress label Oct 26, 2022
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagimeli vagimeli changed the title [DOC:] New page: Discover main page [DOC:] New content and new page: Discover main page and multiple data sources Oct 26, 2022
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. See comments. Otherwise, good to go.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagimeli Please see my comments and changes, and let me know if you have any questions. Thanks!


# Discover

**Discover** in OpenSearch Dashboards helps you extract insights and get value out of organizational-wide data assets. You can quickly ingest and query your data, display that data in visualizations and interactive dashboards, and deliver insights to your organization.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Discover** in OpenSearch Dashboards helps you extract insights and get value out of organizational-wide data assets. You can quickly ingest and query your data, display that data in visualizations and interactive dashboards, and deliver insights to your organization.
**Discover** in OpenSearch Dashboards helps you extract insights and get value out of organization-wide data assets. You can quickly ingest and query your data, display that data in visualizations and interactive dashboards, and deliver insights to your organization.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "get value out of data assets across your organization"?

nav_order: 5
---

Multiple data sources is an experimental feature released in OpenSearch 2.4. We do not recommend using it in a production environment. For updates on the feature’s progress or to leave feedback on improving the feature, see the [OpenSearch Forum discussion](https://forum.opensearch.org/t/feedback-experimental-feature-connect-to-external-data-sources/11144).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Multiple data sources is an experimental feature released in OpenSearch 2.4. We do not recommend using it in a production environment. For updates on the feature’s progress or to leave feedback on improving the feature, see the [OpenSearch Forum discussion](https://forum.opensearch.org/t/feedback-experimental-feature-connect-to-external-data-sources/11144).
Multiple data sources is an experimental feature released in OpenSearch 2.4. We do not recommend using it in a production environment. For updates on the feature’s progress or to leave feedback on the feature, see the [OpenSearch Forum discussion](https://forum.opensearch.org/t/feedback-experimental-feature-connect-to-external-data-sources/11144).

_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
_dashboards/discover/multi-data-sources.md Outdated Show resolved Hide resolved
@vagimeli vagimeli added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 4 - Doc review PR: Doc review in progress labels Nov 2, 2022
@vagimeli vagimeli merged commit eef57a6 into main Nov 2, 2022
@vagimeli
Copy link
Contributor Author

vagimeli commented Nov 2, 2022

Ready for release with OpenSearch 2.4

@vagimeli vagimeli added Closed - Complete Issue: Work is done and associated PRs closed and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Nov 2, 2022
Naarcha-AWS added a commit that referenced this pull request Nov 15, 2022
* Add 2.4 doc release notes

Signed-off-by: Naarcha-AWS <[email protected]>

* Make headings consistent

Signed-off-by: Naarcha-AWS <[email protected]>

* Add intro

Signed-off-by: Naarcha-AWS <[email protected]>

* Add note about in-progress

Signed-off-by: Naarcha-AWS <[email protected]>

* #1711

Signed-off-by: Naarcha-AWS <[email protected]>

Signed-off-by: Naarcha-AWS <[email protected]>
@noCharger
Copy link
Contributor

@vagimeli Thanks for creating the doc! Just curious, is this by design to put the doc under discover section? Since OpenSearch Dashboard also has a feature with same name, I am not sure if people will get confused.

Screen Shot 2022-11-16 at 8 29 23 PM

Screen Shot 2022-11-16 at 8 29 41 PM

@vagimeli
Copy link
Contributor Author

@noCharger We've been restructuring the doc site. Below is the working structure. Will you share your thoughts where multiple data sources best fits in the structure? Thanks!

  • Get started
  • Quickstart
  • Core concepts
  • Discover
  • Dashboard
  • Visualize
  • Maps
  • Reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed - Complete Issue: Work is done and associated PRs closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants