Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Deprecated metrics #6271

Closed
2 of 4 tasks
chibacchie opened this issue Jan 28, 2024 · 2 comments · Fixed by #6331
Closed
2 of 4 tasks

[DOC] Deprecated metrics #6271

chibacchie opened this issue Jan 28, 2024 · 2 comments · Fixed by #6331
Assignees
@Naarcha-AWS
Labels
3 - Done Issue is done/complete performance Documentation related to OpenSearch performance

Comments

@chibacchie
Copy link

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request.

As NodeStatsFixedShardsMetricsCollector has been deprecated by opensearch-project/performance-analyze#551, it should be mentioned in the Metrics reference.

AFAIK, the following metrics collected by NodeStatsFixedShardsMetricsCollector are no longer available.

  • Refresh_Event
  • Refresh_Time
  • Flush_Event
  • Flush_Time
  • Merge_Event
  • Merge_Time
  • Merge_CurrentEvent
  • Indexing_Buffer
  • Segments_Total
  • IndexWriter_Memory
  • Bitset_Memory
  • VersionMap_Memory
  • Shard_Size_In_Bytes

What other resources are available?
@hdhalter
Copy link
Contributor

Hi @khushbr - Can you please confirm whether these should be removed from the documentation?

@khushbr
Copy link

khushbr commented Jan 30, 2024 •
edited
Loading

@hdhalter Yes, we are good to remove these metrics from documentation. @chibacchie Thank you for highlighting this!

@Naarcha-AWS Naarcha-AWS added 1 - Backlog - DOC Doc writer assigned to issue responsible for creating PR. and removed untriaged labels Jan 30, 2024
@Naarcha-AWS Naarcha-AWS self-assigned this Jan 30, 2024
@Naarcha-AWS Naarcha-AWS added performance Documentation related to OpenSearch performance 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog - DOC Doc writer assigned to issue responsible for creating PR. labels Jan 30, 2024
Naarcha-AWS added a commit that referenced this issue Feb 1, 2024
@Naarcha-AWS
Remove depracated PA metrics
b0f2278 
Closes #6271 

Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS Naarcha-AWS mentioned this issue Feb 1, 2024
Merged
1 task
Naarcha-AWS added a commit that referenced this issue Feb 1, 2024
@Naarcha-AWS
Remove depracated PA metrics (#6331)
44aebde 
Closes #6271

Signed-off-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Feb 1, 2024
@github-actions
Remove depracated PA metrics (#6331)
370dc28 
Closes #6271

Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 44aebde)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS pushed a commit that referenced this issue Feb 1, 2024
@opensearch-trigger-bot @github-actions
Remove depracated PA metrics (#6331) (#6332)
33fc4f4 
Closes #6271


(cherry picked from commit 44aebde)

Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Naarcha-AWS Naarcha-AWS

Labels
3 - Done Issue is done/complete performance Documentation related to OpenSearch performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove depracated PA metrics opensearch-project/documentation-website
4 participants
@chibacchie @khushbr @Naarcha-AWS @hdhalter