-
Notifications
You must be signed in to change notification settings - Fork 503
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rewrite Contributing and readme (#4416)
* Rewrite Contributing and readme Signed-off-by: Fanit Kolchina <[email protected]> * Changes to the structure Signed-off-by: Fanit Kolchina <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Reordered sections Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Doc review changes Signed-off-by: Fanit Kolchina <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * added list of resources Signed-off-by: Heather Halter <[email protected]> * Moved front matter section to formatting guide and linting to contributing Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Apply suggestions from code review Co-authored-by: Naarcha-AWS <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Add doc review comments Signed-off-by: Fanit Kolchina <[email protected]> * Delete word Signed-off-by: Fanit Kolchina <[email protected]> * Minor rewording Signed-off-by: Fanit Kolchina <[email protected]> * Change link Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> * Implemented editorial comments Signed-off-by: Fanit Kolchina <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Heather Halter <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Heather Halter <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> Co-authored-by: Nathan Bower <[email protected]>
- Loading branch information
1 parent
9b386b3
commit 5f8ddb8
Showing
3 changed files
with
145 additions
and
159 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,144 @@ | ||
# Contributing Guidelines | ||
- [Creating an issue](#creating-an-issue) | ||
- [Contributing content](#contributing-content) | ||
- [Contribution workflow](#contribution-workflow) | ||
- [Before you start](#before-you-start) | ||
- [Making minor changes](#making-minor-changes) | ||
- [Making major changes](#making-major-changes) | ||
- [Setting up your local copy of the repository](#setting-up-your-local-copy-of-the-repository) | ||
- [Making, viewing, and submitting changes](#making-viewing-and-submitting-changes) | ||
- [Review process](#review-process) | ||
- [Style linting](#style-linting) | ||
- [Getting help](#getting-help) | ||
|
||
Thank you for your interest in improving the OpenSource documentation! We value and appreciate all feedback and contributions from our community, including requests for additional documentation, corrections to existing content, and to report technical issues with the documentation site. | ||
# Contributing guidelines | ||
|
||
The OpenSearch documentation team is dedicated to providing complete and best-in-class documentation. Thank you for your patience as we build our documentation team and content library. We appreciate your support and patience. | ||
Thank you for your interest in improving the OpenSearch documentation! We value and appreciate all feedback and contributions from our community, including requests for additional documentation, corrections to existing content, and reports of technical issues with the documentation site. | ||
|
||
## How to request changes | ||
You can [create an issue](#creating-an-issue) asking us to change the documentation or [contribute content](#contributing-content) yourself. | ||
|
||
Before entering a change request, please read this document carefully. We want to make sure we have all the information necessary to effectively respond to your contribution. | ||
NOTE: If you’d like to contribute but don't know where to start, try browsing existing [issues](https://github.com/opensearch-project/documentation-website/issues). Our projects use custom GitHub issue labels for status, version, type of request, and so on. We recommend starting with any issue labeled "good first issue" if you're a beginner or "help wanted" if you're a more experienced user. | ||
|
||
There are two ways to contribute: 1) create an issue where you describe the change and 2) create a pull request that contains the content to directly insert into the documentation. | ||
## Creating an issue | ||
|
||
**Create an Issue** | ||
Use the documentation issue template to describe the change you'd like to make: | ||
|
||
Use the Github issue tracker to describe the change you'd like to make. | ||
1. Go to https://github.com/opensearch-project/documentation-website/issues and select **New issue**. | ||
1. Enter the requested information, including as much detail as possible, especially which version or versions the request affects. | ||
1. Select **Submit new issue**. | ||
|
||
1. Go to https://github.com/opensearch-project/documentation-website/issues and select *New issue*. | ||
2. Enter the requested information and include as much detail as possible, especially which version or versions the request affects. | ||
3. Select *Submit new issue*. | ||
The `untriaged` label is assigned automatically. During the triage process, the Documentation team will add the appropriate labels, assign the issue to a technical writer, and prioritize the request. We may follow up with you for additional information. | ||
|
||
## Contributing content | ||
|
||
The ‘untriaged’ label is assigned automatically. During the triage process, the documentation team will add the appropriate labels, assign the issue to a technical writer, and prioritize the request. We may follow up with you for additional information. | ||
There are two ways to contribute content, depending on the magnitude of the change: | ||
|
||
- [Minor changes](#making-minor-changes): For small changes to existing files, like fixing typos or adding parameters, you can edit files in GitHub directly. This approach does not require cloning the repository and does not allow you to test the documentation. | ||
- [Major changes](#making-major-changes): For changes you want to test first, like adding new or reorganizing pages or adding a table or section, you can edit files locally and push the changes to GitHub. This approach requires setting up a local version of the repository and allows you to test the documentation. | ||
|
||
**Create a pull request** | ||
### Contribution workflow | ||
|
||
If you’d like to make a change directly to the content, create a pull request. If it’s a quick fix, we should be able to release the update quickly. Bigger requests might take a bit of time for us to review. | ||
The workflow for contributing documentation is the same as the one for contributing code: | ||
|
||
Note that a pull request requires DCO sign off before we can merge it. You can use the -s command line option to append this automatically to your commit message, for example $ git commit -s -m 'This is my commit message'. For more information, see https://github.com/apps/dco. | ||
- Make your changes. | ||
- Build the documentation website to check your work (only possible if you are making changes locally). | ||
- Submit a [pull request](https://github.com/opensearch-project/documentation-website/pulls) (PR). | ||
- A maintainer reviews and merges your PR. | ||
|
||
Before submitting, make sure to: | ||
### Before you start | ||
|
||
* Work against the latest source on the main branch. | ||
* Check existing open and recently merged pull requests to ensure that someone else hasn't addressed the problem already. | ||
* If the change requires significant work, open an issue where we can first discuss your request. | ||
Before contributing content, make sure to read the following resources: | ||
- [README](README.md) | ||
- [OpenSearch Project Style Guidelines](STYLE_GUIDE.md) | ||
- [API Style Guide](API_STYLE_GUIDE.md) | ||
- [Formatting Guide](FORMATTING_GUIDE.md) | ||
|
||
To create a pull request: | ||
NOTE: Make sure that any documentation you submit is your own work or work that you have the right to submit. We respect the intellectual property rights of others, and as part of contributing, we'll ask you to sign your contribution with a [Developer Certificate of Origin (DCO)](https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#developer-certificate-of-origin) stating that you have the right to submit your contribution and that you understand that we will use your contribution. | ||
|
||
1. Fork the repository. | ||
2. Modify the source. Make sure to focus on the specific change you are contributing. For example, if you also reformat the code, it will be hard for us to focus on your change. | ||
3. Test the code. Make sure that any local tests pass. | ||
4. Commit to your fork using clear commit messages. | ||
5. Create the [pull request](https://github.com/opensearch-project/documentation-website/pulls) and save it, making sure to answer the default questions in the pull request template. | ||
### Making minor changes | ||
|
||
If you need additional support, GitHub provides documentation on [forking a repository](https://help.github.com/articles/fork-a-repo/) and [creating a pull request](https://help.github.com/articles/creating-a-pull-request/). | ||
If you want to make minor changes to an existing file, you can use this approach: | ||
|
||
1. [Fork this repository](https://docs.github.com/en/get-started/quickstart/fork-a-repo). | ||
|
||
## Finding contributions to work on | ||
1. In your fork on GitHub, navigate to the file that you want to change. | ||
|
||
If you’d like to contribute but don't know where to start, try browsing existing issues. Our projects use custom GitHub issue labels for status, version, type of request, etc., but we recommend looking at any issues labeled “good first issue” first. | ||
1. In the upper-right corner, select the pencil icon and edit the file. | ||
|
||
1. In the upper-right corner, select **Commit changes...***. Enter the commit message and optional description and select **Create a new branch for this commit and start a pull request**. | ||
|
||
## Security issue notifications | ||
### Making major changes | ||
|
||
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue. | ||
If you're adding a new page or making major changes to the documentation, such as adding new images, sections, or styling, we recommend that you work in a local copy of the repository and test the rendered HTML before submitting a PR. | ||
|
||
#### Setting up your local copy of the repository | ||
|
||
## Licensing | ||
Follow these steps to set up your local copy of the repository: | ||
|
||
See the [LICENSE](LICENSE) file for our project's licensing. | ||
1. [Fork this repository](https://docs.github.com/en/get-started/quickstart/fork-a-repo) and clone your fork. | ||
|
||
1. Navigate to your cloned repository. | ||
|
||
1. Install [Ruby](https://www.ruby-lang.org/en/) if you don't already have it. We recommend [RVM](https://rvm.io/), but you can use any method you prefer: | ||
|
||
``` | ||
curl -sSL https://get.rvm.io | bash -s stable | ||
rvm install 2.7 | ||
ruby -v | ||
``` | ||
|
||
1. Install [Jekyll](https://jekyllrb.com/) if you don't already have it: | ||
|
||
``` | ||
gem install bundler jekyll | ||
``` | ||
|
||
1. Install the Jekyll dependencies: | ||
|
||
``` | ||
bundle install | ||
``` | ||
|
||
#### Making, viewing, and submitting changes | ||
|
||
Here's how to build the website, make changes, and view them locally: | ||
|
||
1. Build the website: | ||
|
||
``` | ||
sh build.sh | ||
``` | ||
|
||
The build script should automatically open your web browser, but if it doesn't, open [http://localhost:4000/docs/](http://localhost:4000/docs/). | ||
|
||
1. Create a new branch against the latest source on the main branch. | ||
|
||
1. Edit the Markdown files that you want to change. | ||
|
||
1. When you save a file, Jekyll automatically rebuilds the site and refreshes your web browser. This process can take 60--90 seconds. | ||
|
||
1. When you're happy with how everything looks, commit, [sign off](https://github.com/src-d/guide/blob/9171d013c648236c39faabcad8598be3c0cf8f56/developer-community/fix-DCO.md#how-to-prevent-missing-sign-offs-in-the-future), push your changes to your fork, and submit a PR. | ||
|
||
Note that a PR requires DCO sign-off before we can merge it. You can use the -s command line option to append this automatically to your commit message, for example, `git commit -s -m 'This is my commit message'`. For more information, see https://github.com/apps/dco. | ||
|
||
## Review process | ||
|
||
We greatly appreciate all contributions to the documentation and will review them as quickly as possible. | ||
|
||
During the PR process, expect that there will be some back-and-forth. If you want your contribution to be merged quickly, try to respond to comments in a timely fashion, and let us know if you don't want to continue with the PR. | ||
|
||
We use the [Vale](https://github.com/errata-ai/vale) linter to ensure that our documentation adheres to the [OpenSearch Project Style Guidelines](STYLE_GUIDE.md). Addressing Vale comments on the PR expedites the review process. You can also install Vale locally so you can address the comments before creating a PR. For more information, see [Style linting](#style-linting). | ||
|
||
If we accept the PR, we will merge it and will backport it to the appropriate branches. | ||
|
||
### Style linting | ||
|
||
To ensure that our documentation adheres to the [OpenSearch Project Style Guidelines](STYLE_GUIDE.md), we use the [Vale](https://github.com/errata-ai/vale) linter. Addressing Vale comments on the PR expedites the review process. You can also install Vale locally as follows so you can address the comments before creating a PR: | ||
|
||
1. Run `brew install vale`. | ||
2. Run `vale *` from the documentation site root directory to lint all Markdown files. To lint a specific file, run `vale /path/to/file`. | ||
|
||
Optionally, you can install the [Vale VSCode](https://github.com/chrischinchilla/vale-vscode) extension, which integrates Vale with Visual Studio Code. By default, only _errors_ and _warnings_ are underlined. To change the minimum alert level to include _suggestions_, go to **Vale VSCode** > **Extension Settings** and select **suggestion** in the **Vale > Vale CLI: Min Alert Level** dropdown list. | ||
|
||
## Getting help | ||
|
||
For help with the contribution process, reach out to one of the [points of contact](README.md#points-of-contact). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.