Bump version to 2.0.0 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 5 5
Lines 149 149
Branches 45 45
=======================================
Hits 142 142
Misses 7 7 Continue to review full report at Codecov.
|
vmmusings
reviewed
Mar 19, 2022
| @@ -24,4 +24,5 @@ module.exports = { | |||
| '\\.(css|less|sass|scss)$': '<rootDir>/test/mocks/styleMock.ts', | |||
| '\\.(gif|ttf|eot|svg)$': '<rootDir>/test/mocks/fileMock.ts', | |||
| }, | |||
| testEnvironment: 'jsdom', | |||
There was a problem hiding this comment.
yes, jest version in dashboards changed, default env is node.js
There was a problem hiding this comment.
Should this be added to dashboards-reports as well?
There was a problem hiding this comment.
depends, reporting have jest for node.js env, need to check separately
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li [email protected]
Description
bump plugin to 2.0
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.