-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README and fix copyright headers #35
Conversation
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 5 5
Lines 149 149
Branches 45 45
=======================================
Hits 142 142
Misses 7 7
Continue to review full report at Codecov.
|
d85d583
to
ab54997
Compare
eec7559
to
cc60ba7
Compare
NOTICE
Outdated
Elasticsearch (http://www.elastic.co). | ||
Copyright 2009-2018 Elasticsearch | ||
--- | ||
This product includes software developed by Plotly (https://plotly.com). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this for third party deps. Curious does all dependencies need to be added? I was checking Dashboards repo which used query-string, but I don't see it listed in the NOTICE file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the letter of the definition: "Distribution generally means shipping or allowing download of works" to use on a user's end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
* Add the project logo to the README file * Fix broken README links to LICENSE and NOTICE * Update copyright notices to short version Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki [email protected]
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.