Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and fix copyright headers #35

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

AMoo-Miki
Copy link
Contributor

@AMoo-Miki AMoo-Miki commented Oct 27, 2021

Signed-off-by: Miki [email protected]

Description

  • Update README and fix copyright notices
  • Add the project logo to the README file
  • Fix broken README links to LICENSE and NOTICE
  • Update copyright headers

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #35 (75a6e59) into main (3aa099e) will not change coverage.
The diff coverage is n/a.

❗ Current head 75a6e59 differs from pull request most recent head ab54997. Consider uploading reports for the commit ab54997 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files           5        5           
  Lines         149      149           
  Branches       45       45           
=======================================
  Hits          142      142           
  Misses          7        7           
Impacted Files Coverage Δ
gantt-chart/public/components/gantt_chart.tsx 90.66% <ø> (ø)
...ntt-chart/public/components/gantt_chart_editor.tsx 100.00% <ø> (ø)
gantt-chart/public/components/options_editor.tsx 100.00% <ø> (ø)
gantt-chart/public/gantt_request_handler.ts 100.00% <ø> (ø)
gantt-chart/public/gantt_vis_type.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa099e...ab54997. Read the comment docs.

@AMoo-Miki AMoo-Miki changed the title Fix LICENSE and NOTICE links, and add project logo Update LICENSE, NOTICE, and README Oct 27, 2021
@AMoo-Miki AMoo-Miki marked this pull request as draft October 27, 2021 17:40
@AMoo-Miki AMoo-Miki force-pushed the readme-fix branch 6 times, most recently from d85d583 to ab54997 Compare November 1, 2021 19:22
@AMoo-Miki AMoo-Miki changed the title Update LICENSE, NOTICE, and README Update README and fix copyright headers Nov 1, 2021
@AMoo-Miki AMoo-Miki marked this pull request as ready for review November 1, 2021 19:29
@AMoo-Miki AMoo-Miki force-pushed the readme-fix branch 3 times, most recently from eec7559 to cc60ba7 Compare November 2, 2021 20:21
NOTICE Outdated
Elasticsearch (http://www.elastic.co).
Copyright 2009-2018 Elasticsearch
---
This product includes software developed by Plotly (https://plotly.com).
Copy link
Member

@joshuali925 joshuali925 Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this for third party deps. Curious does all dependencies need to be added? I was checking Dashboards repo which used query-string, but I don't see it listed in the NOTICE file

Copy link
Contributor Author

@AMoo-Miki AMoo-Miki Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the letter of the definition: "Distribution generally means shipping or allowing download of works" to use on a user's end.

joshuali925
joshuali925 previously approved these changes Nov 2, 2021
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

* Add the project logo to the README file
* Fix broken README links to LICENSE and NOTICE
* Update copyright notices to short version

Signed-off-by: Miki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants