Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename plugin helper config file name to consistent with OSD #31

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

Tengda-He
Copy link
Contributor

@Tengda-He Tengda-He commented Oct 13, 2021

Signed-off-by: Tengda He [email protected]

Description

The previous name of the plugin helper config file is opensearch-dashboards-plugin-helpers.dev.json, which is not consistent with the osd configuration, it might cause the missing of dashboards-visualizations
build config. This pull request is to change the name to .opensearch_dashboards-plugin-helpers.json for consistency.

Issues Resolved

#30

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@joshuali925 joshuali925 merged commit 3aa099e into opensearch-project:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants