Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit jest dependency #25

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

Jest is already a dependency in dashboards core, removing it in gantt chart

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 self-assigned this Sep 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #25 (a0ea17f) into main (ba2911e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files           5        5           
  Lines         149      149           
  Branches       45       45           
=======================================
  Hits          142      142           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2911e...a0ea17f. Read the comment docs.

@joshuali925 joshuali925 merged commit b9eda57 into opensearch-project:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants