Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update search bar snapshot according to upstream change #243

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5101793 from #242.

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 5101793)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
derek-ho previously approved these changes Sep 5, 2023
mengweieric
mengweieric previously approved these changes Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #243 (218c036) into 2.x (2135a1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #243   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

@derek-ho
Copy link
Collaborator

derek-ho commented Sep 5, 2023

Dont merge this yet - looks like it was actually opensearch-project/OpenSearch-Dashboards#4897, which backport failed. Need to fix the test and build workflow, it is incorrectly pointing to main

Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho dismissed stale reviews from mengweieric and themself via 218c036 September 7, 2023 15:44
@derek-ho derek-ho merged commit 68f5fbb into 2.x Sep 7, 2023
@github-actions github-actions bot deleted the backport/backport-242-to-2.x branch September 7, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants