Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline repo groups #174

Merged
merged 2 commits into from
Apr 26, 2023
Merged

baseline repo groups #174

merged 2 commits into from
Apr 26, 2023

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Feb 28, 2023

Description

Baseline repo maintainers and codeowners

Issues Resolved

fix: #163

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho requested a review from a team as a code owner February 28, 2023 16:42
| David Cui | [davidcui1225](https://github.com/davidcui1225) | Amazon |
| Joshua Li | [joshuali925](https://github.com/joshuali925) | Amazon |
| Maintainer | GitHub ID | Affiliation |
| ----------------- | ------------------------------------------------- | ----------- |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need a vote to get @ps48 or @joshuali925 onto this list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure the PR code errors in codeowners file are expected.



    Unknown owner on line 2: make sure @pjfitzgibbons exists and has write access to the repository

    *   @pjfitzgibbons @ps48 @kavithacm @derek-ho @joshuali925 @dai-chen @YANG-DB @rupal-bq @mengweieric @vamsi-amazon @swiddis @penghuo @seankao-az

    Unknown owner on line 2: make sure @derek-ho exists and has write access to the repository

    …jfitzgibbons @ps48 @kavithacm @derek-ho @joshuali925 @dai-chen @YANG-DB @rupal-bq @mengweieric @vamsi-amazon @swiddis @penghuo @seankao-az

    Unknown owner on line 2: make sure @dai-chen exists and has write access to the repository

    …ithacm @derek-ho @joshuali925 @dai-chen @YANG-DB @rupal-bq @mengweieric @vamsi-amazon @swiddis @penghuo @seankao-az

    Unknown owner on line 2: make sure @swiddis exists and has write access to the repository

    …bq @mengweieric @vamsi-amazon @swiddis @penghuo @seankao-az

    Unknown owner on line 2: make sure @penghuo exists and has write access to the repository

    …eieric @vamsi-amazon @swiddis @penghuo @seankao-az

    Unknown owner on line 2: make sure @seankao-az exists and has write access to the repository

    …amsi-amazon @swiddis @penghuo @seankao-az

@codecov-commenter
Copy link

Codecov Report

Merging #174 (95bf4b9) into main (9e1e6dc) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bbarani
Copy link
Member

bbarani commented Apr 25, 2023

Ready to merge. CODEOWNERS is green.

@derek-ho derek-ho merged commit b08ced5 into opensearch-project:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline MAINTAINERS, CODEOWNERS, and external collaborator permissions
6 participants