Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node.js and Yarn installation in CI #166

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

AMoo-Miki
Copy link
Contributor

Description

The GitHub workflow uses the engines from OSD incorrectly. This change fixes that.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki AMoo-Miki requested a review from a team as a code owner February 22, 2023 07:09
@codecov-commenter
Copy link

Codecov Report

Merging #166 (b278b18) into main (81e42ed) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@joshuali925 joshuali925 merged commit 6990ae4 into opensearch-project:main Feb 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 6990ae4)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 6990ae4)
joshuali925 pushed a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 6990ae4)

Co-authored-by: Miki <[email protected]>
joshuali925 pushed a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit 6990ae4)

Co-authored-by: Miki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants