Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX-149] Sanitise duration value #150

Merged

Conversation

m-kalai
Copy link
Contributor

@m-kalai m-kalai commented Jan 3, 2023

Description

Making sure that duration value is actually numeric before plotting the chart.

Issues Resolved

#149

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@m-kalai m-kalai requested a review from a team as a code owner January 3, 2023 16:33
@m-kalai m-kalai force-pushed the fix-149_duration_field_issue branch from e1c89fa to f962b4f Compare January 3, 2023 16:40
@codecov-commenter
Copy link

Codecov Report

Merging #150 (f962b4f) into 2.x (a909771) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              2.x     #150   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           
Impacted Files Coverage Δ
gantt-chart/public/components/gantt_chart.tsx 90.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix
closes #149

@joshuali925 joshuali925 merged commit d7e2f37 into opensearch-project:2.x Jan 4, 2023
@m-kalai m-kalai deleted the fix-149_duration_field_issue branch January 4, 2023 18:45
joshuali925 added a commit that referenced this pull request Jan 10, 2023
Signed-off-by: vamsi-amazon <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Marcel Kalai <[email protected]>
Co-authored-by: vamsi-amazon <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Rupal Mahajan <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
Co-authored-by: Marcel Kalai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants