-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix result text issue #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingkun Ma <[email protected]>
Signed-off-by: Mingkun Ma <[email protected]>
macohen
approved these changes
Nov 10, 2022
Signed-off-by: Mingkun Ma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==========================================
- Coverage 85.04% 81.42% -3.62%
==========================================
Files 9 13 +4
Lines 107 140 +33
Branches 23 27 +4
==========================================
+ Hits 91 114 +23
- Misses 14 24 +10
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
macohen
approved these changes
Nov 11, 2022
github-actions bot
added a commit
that referenced
this pull request
Nov 11, 2022
* feat: Change results number to displayed number Signed-off-by: Mingkun Ma <[email protected]> * fix: Result text wrap Signed-off-by: Mingkun Ma <[email protected]> * fix: Unit test Signed-off-by: Mingkun Ma <[email protected]> Signed-off-by: Mingkun Ma <[email protected]> Co-authored-by: Mingkun Ma <[email protected]> (cherry picked from commit 8fc68ae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 11, 2022
* feat: Change results number to displayed number Signed-off-by: Mingkun Ma <[email protected]> * fix: Result text wrap Signed-off-by: Mingkun Ma <[email protected]> * fix: Unit test Signed-off-by: Mingkun Ma <[email protected]> Signed-off-by: Mingkun Ma <[email protected]> Co-authored-by: Mingkun Ma <[email protected]> (cherry picked from commit 8fc68ae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
macohen
pushed a commit
that referenced
this pull request
Nov 11, 2022
* feat: Change results number to displayed number Signed-off-by: Mingkun Ma <[email protected]> * fix: Result text wrap Signed-off-by: Mingkun Ma <[email protected]> * fix: Unit test Signed-off-by: Mingkun Ma <[email protected]> Signed-off-by: Mingkun Ma <[email protected]> Co-authored-by: Mingkun Ma <[email protected]> (cherry picked from commit 8fc68ae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Mingkun Ma <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Mingkun Ma <[email protected]>
macohen
pushed a commit
that referenced
this pull request
Nov 11, 2022
* feat: Change results number to displayed number Signed-off-by: Mingkun Ma <[email protected]> * fix: Result text wrap Signed-off-by: Mingkun Ma <[email protected]> * fix: Unit test Signed-off-by: Mingkun Ma <[email protected]> Signed-off-by: Mingkun Ma <[email protected]> Co-authored-by: Mingkun Ma <[email protected]> (cherry picked from commit 8fc68ae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Mingkun Ma <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Mingkun Ma <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Closes #69
Preview
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.