Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix result text issue #94

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Fix result text issue #94

merged 6 commits into from
Nov 11, 2022

Conversation

mingkunm
Copy link
Contributor

Description

  • Add a space after every key-value pair
  • Fix text wrap issue

Issues Resolved

Closes #69

Preview

image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mingkunm mingkunm requested a review from a team November 10, 2022 23:10
Signed-off-by: Mingkun Ma <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #94 (6316d60) into main (6325c4d) will decrease coverage by 3.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   85.04%   81.42%   -3.62%     
==========================================
  Files           9       13       +4     
  Lines         107      140      +33     
  Branches       23       27       +4     
==========================================
+ Hits           91      114      +23     
- Misses         14       24      +10     
  Partials        2        2              
Flag Coverage Δ
dashboards-search-relevance 81.42% <ø> (-3.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...earch_components/search_configs/search_configs.tsx 100.00% <0.00%> (ø)
...-search-relevance/public/ace-themes/sql_console.js 100.00% <0.00%> (ø)
...search_components/search_configs/search_config.tsx 50.00% <0.00%> (ø)
...e/public/components/query_compare/create_index.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@macohen macohen merged commit 8fc68ae into opensearch-project:main Nov 11, 2022
github-actions bot added a commit that referenced this pull request Nov 11, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Result text wrap

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Unit test

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 8fc68ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 11, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Result text wrap

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Unit test

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 8fc68ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
macohen pushed a commit that referenced this pull request Nov 11, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Result text wrap

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Unit test

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 8fc68ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Mingkun Ma <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mingkun Ma <[email protected]>
macohen pushed a commit that referenced this pull request Nov 11, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Result text wrap

Signed-off-by: Mingkun Ma <[email protected]>

* fix: Unit test

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 8fc68ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Mingkun Ma <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mingkun Ma <[email protected]>
@mingshl mingshl added the bug Something isn't working label Jan 10, 2023
@mingshl mingshl mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.4 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Line wrapping in 'Compare search results' result list problematic
4 participants