Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test #88

Merged
merged 10 commits into from
Nov 8, 2022
Merged

Unit test #88

merged 10 commits into from
Nov 8, 2022

Conversation

mingkunm
Copy link
Contributor

@mingkunm mingkunm commented Nov 8, 2022

Description

Add unit test to basic components

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mingkunm mingkunm requested a review from a team November 8, 2022 20:59
Copy link
Collaborator

@msfroh msfroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks for adding all of these tests.

Nice to see that we have ~86% line coverage across these components.

@macohen macohen merged commit 909eef1 into opensearch-project:main Nov 8, 2022
@github-actions github-actions bot mentioned this pull request Nov 8, 2022
github-actions bot added a commit that referenced this pull request Nov 8, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* Add babelrc config

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for search bar

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test constants

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result component

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result grid

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for common components

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 909eef1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 8, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* Add babelrc config

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for search bar

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test constants

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result component

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result grid

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for common components

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 909eef1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Nov 8, 2022
macohen pushed a commit that referenced this pull request Nov 9, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* Add babelrc config

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for search bar

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test constants

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result component

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result grid

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for common components

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 909eef1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Mingkun Ma <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mingkun Ma <[email protected]>
macohen pushed a commit that referenced this pull request Nov 9, 2022
* feat: Change results number to displayed number

Signed-off-by: Mingkun Ma <[email protected]>

* Add babelrc config

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for search bar

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test constants

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result component

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for result grid

Signed-off-by: Mingkun Ma <[email protected]>

* Add unit test for common components

Signed-off-by: Mingkun Ma <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
(cherry picked from commit 909eef1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Mingkun Ma <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mingkun Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants