Make srdash compatible with default build script #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
|
Should this also be changed in the template that generated the plugin? |
macohen
approved these changes
Nov 1, 2022
msfroh
approved these changes
Nov 1, 2022
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit c7f7e8f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2022
Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit c7f7e8f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
macohen
pushed a commit
that referenced
this pull request
Nov 1, 2022
Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit c7f7e8f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh
added a commit
that referenced
this pull request
Nov 1, 2022
* chore: Update Cypress version Signed-off-by: Mingkun Ma <[email protected]> * Initial commit for integration test Signed-off-by: Mingkun Ma <[email protected]> * updating backport to 2.0 Signed-off-by: Mark Cohen <[email protected]> * Moving PULL_REQUEST_TEMPLATE.md to .github dir (#35) * moving PR template to .github folder Signed-off-by: Mark Cohen <[email protected]> * moving PR template to .github folder Signed-off-by: Mark Cohen <[email protected]> Signed-off-by: Mark Cohen <[email protected]> * Add windows-latest back to test-and-build workflow (#39) Trying to set the git config for core.longpaths to "true" to enable long file paths on Windows, as that was blocking us from checking out OpenSearch-Dashboards. Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Michael Froh <[email protected]> * Add codeowner (#43) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> * Make srdash compatible with default build script (#46) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Mingkun Ma <[email protected]> Signed-off-by: Mark Cohen <[email protected]> Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Mingkun Ma <[email protected]> Co-authored-by: Mingkun Ma <[email protected]> Co-authored-by: msfroh <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
macohen
pushed a commit
that referenced
this pull request
Nov 1, 2022
Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit c7f7e8f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
macohen
pushed a commit
to macohen/dashboards-search-relevance
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu [email protected]
Description
Make srdash compatible with default build script
Issues Resolved
opensearch-project/opensearch-build#2649
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.