-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove babel-proposal plugins #355
Conversation
Signed-off-by: Sean Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 83.46% 83.54% +0.08%
==========================================
Files 32 32
Lines 393 395 +2
Branches 77 77
==========================================
+ Hits 328 330 +2
Misses 45 45
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sejli Integ test failed, can you look into? Thanks.
|
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
* removing babel proposal Signed-off-by: Sean Li <[email protected]> * updating remote integ test workflow Signed-off-by: Sean Li <[email protected]> * sleep until OSD starts based on api/status Signed-off-by: Sean Li <[email protected]> * increasing sleep time Signed-off-by: Sean Li <[email protected]> * extending request timeout Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit c2f175b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* removing babel proposal * updating remote integ test workflow * sleep until OSD starts based on api/status * increasing sleep time * extending request timeout --------- (cherry picked from commit c2f175b) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
The OSD team updated the
proposal
plugins to theirtransform
equivalents in this PR, which broke our builds. Removingproposal
plugins, as they are not needed.Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.