Remove Experimental Tag #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sejli
requested review from
macohen,
mingshl,
msfroh and
noCharger
as code owners
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 16 16
Lines 209 209
Branches 43 43
=======================================
Hits 188 188
Misses 20 20
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Passes integ tests on local. We have created an issue here to track. |
noCharger
reviewed
Oct 4, 2023
public/components/common/header.tsx
Outdated
Comment on lines
23
to
33
| <EuiText> | ||
| <p> | ||
| Compare results using the same search text with different queries.{' '} | ||
| <EuiLink | ||
| href="https://opensearch.org/docs/latest/search-plugins/search-relevance" | ||
| target="_blank" | ||
| > | ||
| Learn more | ||
| </EuiLink> | ||
| </p> | ||
| </EuiText> |
There was a problem hiding this comment.
Can we make the space between the title and the description seem like this? #144 (comment)
There was a problem hiding this comment.
Trying to find a way to make it similar to the mockups, but I'm not sure if it's possible with EuiPageHeader. I was taking a look at the documentation, there doesn't seem to be a prop to specify position of the description.
There was a problem hiding this comment.
Changed the component to EuiTitle, should match the mockups now.
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
sejli
force-pushed
the
remove-experimental-tag
branch
from
76e3493 to
257adb5
Compare
noCharger
approved these changes
Oct 5, 2023
Signed-off-by: Sean Li <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Oct 5, 2023
* removing experimental tag Signed-off-by: Sean Li <[email protected]> * changing components to match mockups Signed-off-by: Sean Li <[email protected]> * removing unused imports Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 7d062c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
that referenced
this pull request
Oct 5, 2023
* removing experimental tag * changing components to match mockups * removing unused imports --------- (cherry picked from commit 7d062c5) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes experimental tag
Issues Resolved
#144
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.