-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (styles): Make ace editor theme consistent for Search Relevance plugin #300
Conversation
Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]>
Signed-off-by: Nicholas Ung <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 86.27% 83.33% -2.95%
==========================================
Files 15 15
Lines 204 204
Branches 40 40
==========================================
- Hits 176 170 -6
- Misses 26 32 +6
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @nung22! Out of curiosity, did you update the test snapshots manually or by running yarn test -u
?
Changes look good to me. The integration tests are failing for all PRs; we're investigating the issue currently. I'll approve this now and merge this in once we have a solution to the integration test failures.
Sounds good! I updated the snapshots manually after I realized some of the tests were failing with my initial changes. Wasn't aware that you could update them with |
Needed to change the integration tests a little bit since Cypress was having trouble connecting to browser, but tests have been run and passed. Will merge now.
|
…lugin (#300) * Update code editor theme to textmate Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> * Update theme in testing file Signed-off-by: Nicholas Ung <[email protected]> --------- Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> (cherry picked from commit 0b5d9f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…lugin (#300) (#314) * Update code editor theme to textmate * Update theme in testing file --------- (cherry picked from commit 0b5d9f3) Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…lugin (#300) * Update code editor theme to textmate Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> * Update theme in testing file Signed-off-by: Nicholas Ung <[email protected]> --------- Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> (cherry picked from commit 0b5d9f3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-search-relevance/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/dashboards-search-relevance/backport-2.11
# Create a new branch
git switch --create backport-300-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b5d9f3b67961d0473497f062a6874eb0d39ee6b
# Push it to GitHub
git push --set-upstream origin backport-300-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-search-relevance/backport-2.11 Then, create a pull request where the |
…lugin (opensearch-project#300) * Update code editor theme to textmate Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> * Update theme in testing file Signed-off-by: Nicholas Ung <[email protected]> --------- Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> (cherry picked from commit 0b5d9f3)
…lugin (#300) (#327) * Update code editor theme to textmate * Update theme in testing file --------- (cherry picked from commit 0b5d9f3) Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: Nicholas Ung <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fixes inconsistent editor theming in dark mode for Search Relevance plugin by using "textmate" theme rather than "sql_console". Builds off solution discussed in opensearch-project/OpenSearch-Dashboards#4609.
Issues Resolved
Closes #307
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screenshots
Before
Editor is still in light mode while site is in dark mode:
After
Editor and site are now both in dark mode: