-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a developer guide #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
…the config name Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
…ebsite and because we should have one to encourage contributions Signed-off-by: Mark Cohen <[email protected]>
macohen
requested review from
mingshl,
msfroh,
noCharger and
sejli
as code owners
August 30, 2023 22:18
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 15 15
Lines 204 204
Branches 40 40
=======================================
Hits 176 176
Misses 26 26
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. |
sejli
approved these changes
Aug 30, 2023
github-actions bot
added a commit
that referenced
this pull request
Aug 31, 2023
* adding release notes for 2.7.0 Signed-off-by: Mark Cohen <[email protected]> * categorizing release notes Signed-off-by: Mark Cohen <[email protected]> * added on->pull_request Signed-off-by: Mark Cohen <[email protected]> * testing a default config from the release-drafter repo; only changed the config name Signed-off-by: Mark Cohen <[email protected]> * removed cypress builds; recategorized some PRs, renamed metrics PR Signed-off-by: Mark Cohen <[email protected]> * adding developer guide to reference from source.html on the project website and because we should have one to encourage contributions Signed-off-by: Mark Cohen <[email protected]> --------- Signed-off-by: Mark Cohen <[email protected]> (cherry picked from commit 77124d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
that referenced
this pull request
Aug 31, 2023
* adding release notes for 2.7.0 * categorizing release notes * added on->pull_request * testing a default config from the release-drafter repo; only changed the config name * removed cypress builds; recategorized some PRs, renamed metrics PR * adding developer guide to reference from source.html on the project website and because we should have one to encourage contributions --------- (cherry picked from commit 77124d5) Signed-off-by: Mark Cohen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
It seems that the links in the section "Run Docker" are dead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helps developers understand how to build this plugin and will be referenced from opensearch.org/source.html.
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.