Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixing typo in integ test workflow #236

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

sejli
Copy link
Member

@sejli sejli commented Jul 11, 2023

Description

Fixes typo in GitHub variable. Previously, the workflow would only work on main branch.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mingshl mingshl added the CI continuous integration enhancement label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #236 (09b8205) into main (dd6f4d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          15       15           
  Lines         204      204           
  Branches       40       40           
=======================================
  Hits          176      176           
  Misses         26       26           
  Partials        2        2           
Flag Coverage Δ
dashboards-search-relevance 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sejli sejli merged commit 17acc14 into opensearch-project:main Jul 11, 2023
@github-actions
Copy link

The backport to 2.8 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-search-relevance/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/dashboards-search-relevance/backport-2.8
# Create a new branch
git switch --create backport-236-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 17acc146fe0befa3b4181efc1b15397b89074d1c
# Push it to GitHub
git push --set-upstream origin backport-236-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-search-relevance/backport-2.8

Then, create a pull request where the base branch is 2.8 and the compare/head branch is backport-236-to-2.8.

github-actions bot added a commit that referenced this pull request Jul 11, 2023
* fixing typo in integ test workflow

Signed-off-by: Sean Li <[email protected]>

* adding change to release notes

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 17acc14)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli pushed a commit that referenced this pull request Jul 11, 2023
* fixing typo in integ test workflow



* adding change to release notes



---------


(cherry picked from commit 17acc14)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.8 CI continuous integration enhancement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants