Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling back to anomaly-detection for OS dependency in workflow #230

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

sejli
Copy link
Member

@sejli sejli commented Jul 10, 2023

Description

Fixes an issue where the workaround using search-processor to build OpenSearch fails to integrate with OpenSearch Dashboards

Issues Resolved

#221

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sejli added 2 commits July 10, 2023 14:24
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #230 (5300061) into main (7cd9f4e) will not change coverage.
The diff coverage is n/a.

❗ Current head 5300061 differs from pull request most recent head 641832a. Consider uploading reports for the commit 641832a to get more accurate results

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          15       15           
  Lines         204      204           
  Branches       40       40           
=======================================
  Hits          176      176           
  Misses         26       26           
  Partials        2        2           
Flag Coverage Δ
dashboards-search-relevance 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

The backport to test-backport failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-search-relevance/backport-test-backport test-backport
# Navigate to the new working tree
pushd ../.worktrees/dashboards-search-relevance/backport-test-backport
# Create a new branch
git switch --create backport-230-to-test-backport
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8b8cc11de9e0d530c9250434d4b581cc753ee762
# Push it to GitHub
git push --set-upstream origin backport-230-to-test-backport
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-search-relevance/backport-test-backport

Then, create a pull request where the base branch is test-backport and the compare/head branch is backport-230-to-test-backport.

github-actions bot added a commit that referenced this pull request Jul 10, 2023
* rolling back to anomaly-detection for OS

Signed-off-by: Sean Li <[email protected]>

* typo

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 8b8cc11)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mingshl mingshl added CI continuous integration enhancement backport 2.8 labels Jul 10, 2023
github-actions bot added a commit that referenced this pull request Jul 10, 2023
* rolling back to anomaly-detection for OS

Signed-off-by: Sean Li <[email protected]>

* typo

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 8b8cc11)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl pushed a commit that referenced this pull request Jul 10, 2023
#233)

* rolling back to anomaly-detection for O
---------
(cherry picked from commit 8b8cc11)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mingshl mingshl added the v2.9.0 label Jul 10, 2023
mingshl pushed a commit that referenced this pull request Jul 10, 2023
#232)

* rolling back to anomaly-detection for OS

---------


(cherry picked from commit 8b8cc11)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@noCharger
Copy link
Collaborator

@sejli This is a short term mitigation. Please post your research in #221. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.8 CI continuous integration enhancement v2.9.0
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants