-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build branch name #208
fix build branch name #208
Conversation
Signed-off-by: Mingshi Liu <[email protected]>
be9698d
to
0d7c713
Compare
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 15 15
Lines 204 204
Branches 40 40
=======================================
Hits 176 176
Misses 26 26
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ac983f6
to
5cca330
Compare
Signed-off-by: Mingshi Liu <[email protected]>
5cca330
to
53a03ed
Compare
elif [[ "${{ github.event_name }}" == "pull_request" ]]; then | ||
echo "Base branch name is "${{ github.event.pull_request.base.ref }}"" | ||
BRANCH_NAME="${{ github.event.pull_request.base.ref }}" | ||
fi | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with nit.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport-208-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b58246eae39af426fcd9aa03182409be05bcd15
# Push it to GitHub
git push --set-upstream origin backport-208-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.8 2.8
# Navigate to the new working tree
pushd ../.worktrees/backport-2.8
# Create a new branch
git switch --create backport-208-to-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b58246eae39af426fcd9aa03182409be05bcd15
# Push it to GitHub
git push --set-upstream origin backport-208-to-2.8
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.8 Then, create a pull request where the |
* fix build branch name Signed-off-by: Mingshi Liu <[email protected]> * test workflow with new pushes Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 3b58246)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport-208-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b58246eae39af426fcd9aa03182409be05bcd15
# Push it to GitHub
git push --set-upstream origin backport-208-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* fix build branch name Signed-off-by: Mingshi Liu <[email protected]> * test workflow with new pushes Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 3b58246)
* fix build branch name Signed-off-by: Mingshi Liu <[email protected]> * test workflow with new pushes Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 3b58246) Co-authored-by: Mingshi Liu <[email protected]>
* fix build branch name Signed-off-by: Mingshi Liu <[email protected]> * test workflow with new pushes Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 3b58246)
* fix build branch name Signed-off-by: Mingshi Liu <[email protected]> * test workflow with new pushes Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 3b58246)
* fix build branch name Signed-off-by: Mingshi Liu <[email protected]> * test workflow with new pushes Signed-off-by: Mingshi Liu <[email protected]> --------- Signed-off-by: Mingshi Liu <[email protected]> Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit 3b58246) Co-authored-by: Mingshi Liu <[email protected]>
Description
fix build branch name
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.