[Backport 2.x] adding Mingshi Liu as a maintainer so she can be release manager (#112) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsearch-project#112) Signed-off-by: Mark Cohen <[email protected]> Signed-off-by: Mark Cohen <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
mingshl
changed the title
msfroh
approved these changes
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #126 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 13 13
Lines 140 140
Branches 27 27
=======================================
Hits 114 114
Misses 24 24
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
we should remove the backport label for a backport PR https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/RELEASING.md#how-to-validate-that-merged-commits-have-been-properly-backported Also we should avoid backport manually. Add the label to the original pr on main branch and it will create the backport PR automatically |
|
Please close this one and use #127 |
|
closed the manual backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 'efaaeff' from 112