Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version for ansi-regex, gs, glob-parent and update yarn.lock #113

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Jan 6, 2023

Previous commit didn't include update to yarn.lock.

To address the following CVEs:

CVE-2021-3807 - Inefficient Regular Expression Complexity in
chalk/ansi-regex
CVE-2022-24999 - Improperly Controlled Modification of Object
Prototype Attributes ('Prototype Pollution'),
qs vulnerable to Prototype Pollution
GMS-2022-3113 - glob-parent before 6.0.1 and 5.1.2 vulnerable to
Regular Expression Denial of Service (ReDoS)

Signed-off-by: Michael Froh [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@msfroh msfroh requested a review from a team January 6, 2023 19:26
yarn.lock Outdated
Comment on lines 86 to 103
version "18.11.18"
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.18.tgz#8dfb97f0da23c2293e554c5a50d61ef134d7697f"
integrity sha512-DHQpWGjyQKSHj3ebjFI/wRKcqQcdR+MoFBygntYOZytCqNfkd2ZC4ARDJ2DQqhjH5p85Nnd3jhUJIXrszFX/JA==

"@types/node@^14.14.31":
version "14.18.33"
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.33.tgz#8c29a0036771569662e4635790ffa9e057db379b"
integrity sha512-qelS/Ra6sacc4loe/3MSjXNL1dNQ/GjxNHVzuChwMfmk7HuycRLVQN2qNY3XahK+fZc5E2szqQSKUyAF0E+2bg==
version "14.18.36"
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.36.tgz#c414052cb9d43fab67d679d5f3c641be911f5835"
integrity sha512-FXKWbsJ6a1hIrRxv+FoukuHnGTgEzKYGi7kilfMae96AL9UNkPFNWJEEYWzdRI9ooIkbr4AKldyuSTLql06vLQ==

"@types/prop-types@*":
version "15.7.5"
resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.5.tgz#5f19d2b85a98e9558036f6a3cacc8819420f05cf"
integrity sha512-JCB8C6SnDoQf0cNycqd/35A7MjcnK+ZTqE7judS6o7utxUCg6imJg3QK2qzHKszlTjcj2cn+NwMB2i96ubpj7w==

"@types/react@*":
version "18.0.25"
resolved "https://registry.yarnpkg.com/@types/react/-/react-18.0.25.tgz#8b1dcd7e56fe7315535a4af25435e0bb55c8ae44"
integrity sha512-xD6c0KDT4m7n9uD4ZHi02lzskaiqcBxf4zi+tXZY98a04wvc0hi/TcCPC2FOESZi51Nd7tlUeOJY8RofL799/g==
version "18.0.26"
resolved "https://registry.yarnpkg.com/@types/react/-/react-18.0.26.tgz#8ad59fc01fef8eaf5c74f4ea392621749f0b7917"
integrity sha512-hCR3PJQsAIXyxhTNSiDFY//LhnMZWpNNr5etoCqx/iUfGc5gXWtQR2Phl908jVR6uPXacojQWTg4qRpkxTuGug==
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msfroh Is it necessary to update the react and node versions? I'm not sure if this is compatible with OSD...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what happened when I ran yarn install. I didn't make this choice.

My plugin repo was under the latest OSD.

yarn.lock Outdated
Comment on lines 339 to 342
ci-info@^3.2.0:
version "3.5.0"
resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.5.0.tgz#bfac2a29263de4c829d806b1ab478e35091e171f"
integrity sha512-yH4RezKOGlOhxkmhbeNuC4eYZKAUsEaGtBuBzDDP1eFUKiccDWzBABxBfOx31IDwDIXMTxWuwAxUGModvkbuVw==
version "3.7.1"
resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.7.1.tgz#708a6cdae38915d597afdf3b145f2f8e1ff55f3f"
integrity sha512-4jYS4MOAaCIStSRwiuxc4B8MYhIe676yO1sYGzARnjXkWpmzZMMYxY6zu8WYWDhSuth5zhrQ1rhNSibyyvv4/w==
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also related to the CVE?

@msfroh msfroh added 2.x 2.x branch backport 2.x labels Jan 9, 2023
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve based on building pass

Previous commit didn't include update to yarn.lock.

Signed-off-by: Michael Froh <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #113 (370b29d) into main (efaaeff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          13       13           
  Lines         140      140           
  Branches       27       27           
=======================================
  Hits          114      114           
  Misses         24       24           
  Partials        2        2           
Flag Coverage Δ
dashboards-search-relevance 81.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noCharger noCharger merged commit 534983f into opensearch-project:main Jan 9, 2023
github-actions bot added a commit that referenced this pull request Jan 9, 2023
Previous commit didn't include update to yarn.lock.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit 534983f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jan 9, 2023
Previous commit didn't include update to yarn.lock.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit 534983f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Jan 9, 2023
Previous commit didn't include update to yarn.lock.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit 534983f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger pushed a commit that referenced this pull request Jan 9, 2023
Previous commit didn't include update to yarn.lock.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit 534983f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mingshl mingshl changed the title Update yarn.lock Bump version for ansi-regex, gs, and glob-parent and Update yarn.lock Jan 11, 2023
@mingshl mingshl changed the title Bump version for ansi-regex, gs, and glob-parent and Update yarn.lock Bump version for ansi-regex, gs, glob-parent and Update yarn.lock Jan 11, 2023
@mingshl mingshl changed the title Bump version for ansi-regex, gs, glob-parent and Update yarn.lock Bump version for ansi-regex, gs, glob-parent and update yarn.lock Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants