Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test Coverage Threshold #101

Merged
merged 10 commits into from
Dec 8, 2022
Merged

Unit Test Coverage Threshold #101

merged 10 commits into from
Dec 8, 2022

Conversation

macohen
Copy link
Collaborator

@macohen macohen commented Nov 14, 2022

Description

  • Setting unit test coverage target to 80% with a 2% threshold. Builds will fail if coverage hits 78%.
  • Adding pull request stats action to test

Issues Resolved

Closes #98

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@macohen macohen requested a review from a team November 14, 2022 14:58
@codecov-commenter
Copy link

Codecov Report

Merging #101 (026c9f7) into main (8fc68ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          13       13           
  Lines         140      140           
  Branches       27       27           
=======================================
  Hits          114      114           
  Misses         24       24           
  Partials        2        2           
Flag Coverage Δ
dashboards-search-relevance 81.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

macohen and others added 5 commits November 14, 2022 10:36
* renamed files with typos from serach* to search*

Signed-off-by: Mark Cohen <[email protected]>

* testing a PR stats workflow

Signed-off-by: Mark Cohen <[email protected]>

Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
@macohen macohen requested a review from msfroh December 7, 2022 15:05
@msfroh msfroh merged commit 052c593 into opensearch-project:main Dec 8, 2022
mingshl pushed a commit to mingshl/mingshl-dashboards-search-relevance-2.5release that referenced this pull request Jan 9, 2023
* Setting unit test coverage target to 80% with a 2% threshold. Builds will fail if coverage hits 78%.
* Adding pull request stats action to test.

Signed-off-by: Mark Cohen <[email protected]>
Co-authored-by: Mark Cohen <[email protected]>
Signed-off-by: Mingshi Liu <[email protected]>
mingshl added a commit that referenced this pull request Jan 9, 2023
* Setting unit test coverage target to 80% with a 2% threshold. Builds will fail if coverage hits 78%.
* Adding pull request stats action to test.

Signed-off-by: Mark Cohen <[email protected]>
Co-authored-by: Mark Cohen <[email protected]>
Signed-off-by: Mingshi Liu <[email protected]>

Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mingshi Liu <[email protected]>
Co-authored-by: Mark Cohen <[email protected]>
Co-authored-by: Mark Cohen <[email protected]>
@mingshl mingshl added the infra Infrastructure/Build/Platform Changes label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure/Build/Platform Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL] Code Coverage Threshold
4 participants