Bump version to 2.0.0 #311
Conversation
Signed-off-by: Eugene Lee <[email protected]>
There was a problem hiding this comment.
reports-dashbaords CI failed, please check. I'd also suggest that you post draft PR first and make sure all github actions pass, no reviewers will be notified for a draft PR, you can make any modifications. Then you can convert to regular PR and request reviews.
| @@ -19,4 +19,5 @@ module.exports = { | |||
| '\\.(css|less|sass|scss)$': '<rootDir>/test/__mocks__/styleMock.js', | |||
| '\\.(gif|ttf|eot|svg)$': '<rootDir>/test/__mocks__/fileMock.js', | |||
| }, | |||
| testEnvironment: 'jsdom', | |||
There was a problem hiding this comment.
@joshuali925 This was added in sql so I added just in case but I am not sure if it is needed in reporting. opensearch-project/dashboards-visualizations#56 (comment)
There was a problem hiding this comment.
Does removing this testEnvironment config help unblock the front-end CI workflow?
There was a problem hiding this comment.
Unfortunately it did not
Signed-off-by: Eugene Lee <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
============================================
- Coverage 73.01% 72.64% -0.37%
Complexity 373 373
============================================
Files 94 94
Lines 3928 3963 +35
Branches 609 644 +35
============================================
+ Hits 2868 2879 +11
- Misses 885 909 +24
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Eugene Lee <[email protected]>
Signed-off-by: Eugene Lee <[email protected]>
Signed-off-by: David Cui <[email protected]>
Signed-off-by: David Cui <[email protected]>
|
All workflows are passing now- @eugenesk24 any other steps needed before making this PR ready for review? |
* Bump version to 2.0 Signed-off-by: Eugene Lee <[email protected]> Co-authored-by: David Cui <[email protected]>
Signed-off-by: Eugene Lee [email protected]
Description
Bump version to 2.0.0
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.