Add tesseract and foreign object rendering #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
joshuali925
requested review from
anirudha,
nknize,
ps48,
kavithacm,
zhongnansu,
sejli,
davidcui1225,
rupal-bq,
CEHENKLE,
mengweieric,
eugenesk24 and
vmmusings
as code owners
rupal-bq
approved these changes
Apr 7, 2023
Signed-off-by: Joshua Li <[email protected]>
ps48
reviewed
Apr 11, 2023
common/tesseract/eng.traineddata.gz
Outdated
There was a problem hiding this comment.
Couple of questions here:
- Do we want to keep this static? or download the latest model during build?
- If the prior then are we planning to update the model every release?
There was a problem hiding this comment.
good point, thanks, will remove from git and download after bootstrap
The model is coupled with tesseract version and latest model was from 4 years ago, i don't think we can have automated updates to the model
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
ps48
approved these changes
Apr 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 503ee05)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 503ee05)
rupal-bq
pushed a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 503ee05) Co-authored-by: Joshua Li <[email protected]>
rupal-bq
pushed a commit
that referenced
this pull request
Apr 11, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 503ee05) Co-authored-by: Joshua Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#69 #83
Issues Resolved
closes #69
closes #83
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.