Update 1.x to be same as Reporting Repo #7
Conversation
* Add workaround for ERR_ADDRESS_INVALID in doc Signed-off-by: Rupal Mahajan <[email protected]> * nit Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit c5bb86acbe38e2d4946b71ca287253a9cf4d853e) Co-authored-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]> (cherry picked from commit 3240685444bc4c5aac23bdecad5b6c480d5a3d89) Co-authored-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
* Add docs Signed-off-by: Rupal Mahajan <[email protected]> * Update docs to repo name change Signed-off-by: Rupal Mahajan <[email protected]> * Updated MAINTAINERS.md to match recommended opensearch-project format. Signed-off-by: Rupal Mahajan <[email protected]> Signed-off-by: Rupal Mahajan <[email protected]>
This reverts commit 171cd23. Signed-off-by: Rupal Mahajan <[email protected]>
|
Please see my comment in #6 I think this should be done as a forward-merge from |
assuming forward-merge means |
| - name: Checkout Plugin | ||
| uses: actions/checkout@v1 | ||
| with: | ||
| path: OpenSearch-Dashboards/plugins/${{ env.PLUGIN_NAME }} | ||
|
|
||
| - name: Add Chromium Binary to Reporting for Testing |
There was a problem hiding this comment.
Should this step no longer be used?
There was a problem hiding this comment.
remove chromium changes are not backported to 1.x (assuming 1.4 release is not planned). Only backported to 1.3 branch for possible next patch release. I will double check this while raising PR for 1.3
| cd build | ||
| mkdir -p ./{linux-x64,linux-arm64}/opensearch-dashboards/${{ env.PLUGIN_NAME }} | ||
| cp ./${{ env.PLUGIN_NAME }}-*.zip ./linux-x64/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}-linux-x64.zip | ||
| cp ./${{ env.PLUGIN_NAME }}-*.zip ./linux-arm64/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}-linux-arm64.zip | ||
|
|
||
| cd linux-x64 | ||
| wget https://github.com/opensearch-project/dashboards-reports/releases/download/chromium-1.12.0.0/chromium-linux-x64.zip |
There was a problem hiding this comment.
Also I believe the artifacts no longer need to wrap the chromium zip?
There was a problem hiding this comment.
same reason for this. changes are not backported to 1.x.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.