Update scrollX and scrollY values for html2canvas #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
rupal-bq
approved these changes
Jan 13, 2023
vmmusings
approved these changes
Jan 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
This was referenced Jan 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
that referenced
this pull request
Jan 13, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8) Co-authored-by: Joshua Li <[email protected]>
joshuali925
added a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8) Co-authored-by: Joshua Li <[email protected]>
joshuali925
added a commit
to joshuali925/dashboards-reporting
that referenced
this pull request
Jan 17, 2023
) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
to joshuali925/dashboards-reporting
that referenced
this pull request
Jan 17, 2023
) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
to joshuali925/dashboards-reporting
that referenced
this pull request
Jan 17, 2023
) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
to joshuali925/dashboards-reporting
that referenced
this pull request
Jan 17, 2023
) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
to joshuali925/dashboards-reporting
that referenced
this pull request
Jan 17, 2023
) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
joshuali925
added a commit
that referenced
this pull request
Jan 17, 2023
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7a60ae8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li [email protected]
Description
Force scrollX and scrollY to be zero instead of actual values, otherwise if user scrolls down or right, the image will have a blank margin on top or left
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.