Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix the bootstrap failure on the fresh run #270

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Jan 9, 2024

Description

Fix the bootstrap failure on the fresh run.

Thanks to @joshuali925 's comment (#263 (comment)). In this PR I have updated the yarn.lock file and removed the retries in the current CI workflows.

  • Updated the yarn.lock
  • Removed the retries for dashboards bootstraps for 2 workflows
  • Updated the snapshots

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997
Copy link
Contributor Author

After updating the dependencies, the snapshots tests had some failures https://github.com/opensearch-project/dashboards-reporting/actions/runs/7465626149/job/20315223211?pr=270#step:5:3228. The similar behavior also happened for query-workbench (see comment). I have updated the snapshot by running yarn test -u.

@RyanL1997
Copy link
Contributor Author

RyanL1997 commented Jan 9, 2024

Right now the previous issue got fixed since the runner can bootstrap the plugin on a fresh run without a single retry: https://github.com/opensearch-project/dashboards-reporting/actions/runs/7465626033/job/20315215449?pr=270#step:18:18

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdaa926) 74.47% compared to head (88c7a83) 74.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   74.47%   74.47%           
=======================================
  Files          30       30           
  Lines        1904     1904           
  Branches      410      410           
=======================================
  Hits         1418     1418           
  Misses        483      483           
  Partials        3        3           
Flag Coverage Δ
dashboards-report 74.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48
Copy link
Member

ps48 commented Jan 9, 2024

@RyanL1997 Does this need backport 2.x label? Also, is there no change for package.json file are we directly updating yarn.lock?

@RyanL1997
Copy link
Contributor Author

RyanL1997 commented Jan 9, 2024

@RyanL1997 Does this need backport 2.x label? Also, is there no change for package.json file are we directly updating yarn.lock?

Hi @ps48 . Yesterday, I did the version change in #268, so it should be fine to just update the yarn.lock here. I will backport them together into 2x btw.

@ps48 ps48 merged commit 09cb4c1 into opensearch-project:main Jan 9, 2024
9 of 11 checks passed
RyanL1997 added a commit to RyanL1997/dashboards-reporting that referenced this pull request Jan 9, 2024
…ect#270)

* Update the yarn.lock and remove the retries for plugins bootstrap in CIs

Signed-off-by: Ryan Liang <[email protected]>

* Update the snapshots

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
ps48 pushed a commit that referenced this pull request Jan 9, 2024
…p reporting plugin during a fresh run (#271)

* Sync dependencies with latest versions (#268)

Signed-off-by: Ryan Liang <[email protected]>

* [Bug Fix] Fix the bootstrap failure on the fresh run (#270)

* Update the yarn.lock and remove the retries for plugins bootstrap in CIs

Signed-off-by: Ryan Liang <[email protected]>

* Update the snapshots

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failure during the running of yarn osd bootstrap
3 participants