-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] Fix the bootstrap failure on the fresh run #270
[Bug Fix] Fix the bootstrap failure on the fresh run #270
Conversation
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
After updating the dependencies, the snapshots tests had some failures https://github.com/opensearch-project/dashboards-reporting/actions/runs/7465626149/job/20315223211?pr=270#step:5:3228. The similar behavior also happened for query-workbench (see comment). I have updated the snapshot by running |
Right now the previous issue got fixed since the runner can bootstrap the plugin on a fresh run without a single retry: https://github.com/opensearch-project/dashboards-reporting/actions/runs/7465626033/job/20315215449?pr=270#step:18:18 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 30 30
Lines 1904 1904
Branches 410 410
=======================================
Hits 1418 1418
Misses 483 483
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@RyanL1997 Does this need backport 2.x label? Also, is there no change for package.json file are we directly updating yarn.lock? |
Hi @ps48 . Yesterday, I did the version change in #268, so it should be fine to just update the |
…ect#270) * Update the yarn.lock and remove the retries for plugins bootstrap in CIs Signed-off-by: Ryan Liang <[email protected]> * Update the snapshots Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
…p reporting plugin during a fresh run (#271) * Sync dependencies with latest versions (#268) Signed-off-by: Ryan Liang <[email protected]> * [Bug Fix] Fix the bootstrap failure on the fresh run (#270) * Update the yarn.lock and remove the retries for plugins bootstrap in CIs Signed-off-by: Ryan Liang <[email protected]> * Update the snapshots Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
Description
Fix the bootstrap failure on the fresh run.
Thanks to @joshuali925 's comment (#263 (comment)). In this PR I have updated the
yarn.lock
file and removed the retries in the current CI workflows.yarn.lock
Issues Resolved
yarn osd bootstrap
#263Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.