-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/CD] Add E2E Cypress workflow for Dashboards Reporting #262
[CI/CD] Add E2E Cypress workflow for Dashboards Reporting #262
Conversation
Signed-off-by: Ryan Liang <[email protected]>
9ae69fa
to
89f03a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 30 30
Lines 1904 1904
Branches 410 410
=======================================
Hits 1418 1418
Misses 483 483
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2e51fdd
to
89f03a2
Compare
Signed-off-by: Ryan Liang <[email protected]>
bf0a569
to
a790f6b
Compare
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
working-directory: OpenSearch-Dashboards | ||
shell: bash | ||
|
||
- name: OpenSearch Dashboards Plugin Bootstrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here goes a super wired error: https://github.com/opensearch-project/dashboards-reporting/actions/runs/7228046528/job/19696789121?pr=262#step:17:154
I can reproduce it on my local only during the first run of yarn osd bootstrap . And if I re-run it after it fails, then it works again..
So in the current commit, I added max 3 re-tries for the bootstrap step, and it got the CI works.. but in the 1st try, you can see the exactly the same error: https://github.com/opensearch-project/dashboards-reporting/actions/runs/7228507642/job/19698061142?pr=262#step:17:166
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transferring some of the conversation between me and @ps48 here:
We think it is fine to do this CI work here first and then we address the above bootstrap issue, since we have a current workaround on that, so that it is not a hard blocker. I will file an issue to track that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking issue is here: #263
…-project#262) * [CI/CD] Add E2E Cypress workflow for Dashboards Reporting Signed-off-by: Ryan Liang <[email protected]> * Enable multiple try for bootstrap Signed-off-by: Ryan Liang <[email protected]> * Add 3 times retry for osd bootstrap Signed-off-by: Ryan Liang <[email protected]> * Correct the name of the job and title Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
* [CI/CD] Add E2E Cypress workflow for Dashboards Reporting (#262) * [CI/CD] Add E2E Cypress workflow for Dashboards Reporting Signed-off-by: Ryan Liang <[email protected]> * Enable multiple try for bootstrap Signed-off-by: Ryan Liang <[email protected]> * Add 3 times retry for osd bootstrap Signed-off-by: Ryan Liang <[email protected]> * Correct the name of the job and title Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> * [Backport 2.x] Add E2E Cypress workflow for Dashboards Reporting Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
Description
Add E2E Cypress workflow for Dashboards Reporting
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.