Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support reporting for new discover #184

Merged
merged 2 commits into from
Sep 15, 2023
Merged

support reporting for new discover #184

merged 2 commits into from
Sep 15, 2023

Conversation

joshuali925
Copy link
Member

Description

  • discover url changed to data-explorer and discoverLegacy, update the server validations accordingly
  • core menu classname and children length changed. temporarily fix those for now. long term fix should be using registerMenuItem API and tracked in [BUG] Refactor context menu #118

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 marked this pull request as draft September 15, 2023 17:00
@joshuali925 joshuali925 marked this pull request as ready for review September 15, 2023 17:24
@joshuali925 joshuali925 marked this pull request as draft September 15, 2023 17:53
@joshuali925 joshuali925 marked this pull request as ready for review September 15, 2023 17:58
@joshuali925
Copy link
Member Author

not sure what's wrong with my browser, with /app/data-explorer/discover, fetch('../../api/xxx') should be correct but sometimes it needs fetch('../../../api/xxx'). will leave it as two levels up for now

@joshuali925 joshuali925 merged commit baafdf1 into opensearch-project:main Sep 15, 2023
12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 15, 2023
@github-actions
support reporting for new discover (#184)
194e4bf 
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit baafdf1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 15, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 15, 2023
@github-actions
support reporting for new discover (#184)
befdb72 
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit baafdf1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 15, 2023
Merged
joshuali925 pushed a commit that referenced this pull request Sep 15, 2023
@opensearch-trigger-bot @github-actions
support reporting for new discover (#184) (#185)
db6068f 
(cherry picked from commit baafdf1)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925 pushed a commit that referenced this pull request Sep 15, 2023
@opensearch-trigger-bot @github-actions
support reporting for new discover (#184) (#186)
379adef 
(cherry picked from commit baafdf1)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joshuali925
Copy link
Member Author

not sure what's wrong with my browser, with /app/data-explorer/discover, fetch('../../api/xxx') should be correct but sometimes it needs fetch('../../../api/xxx'). will leave it as two levels up for now

#190 fixes this, new discover URL sometimes uses ....discover/#/xxx and sometimes it's ....discover#/xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derek-ho derek-ho derek-ho left review comments

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ps48 ps48 ps48 approved these changes

@anirudha anirudha anirudha approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshuali925 @anirudha @ps48 @ashwin-pc @derek-ho