Update Developer guide #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
joshuali925
reviewed
Jan 6, 2023
| git config core.sparseCheckout true | ||
| git checkout dev | ||
| git clone https://github.com/opensearch-project/dashboards-reporting.git plugins/dashboards-reporting | ||
| git checkout main |
There was a problem hiding this comment.
not sure if it's intentional but the first command clones dashboards-reporting, the second command checks out main of dashboards core. also checkout main of reporting is not necessary since it's default
maybe
cd plugins
git clone https://github.com/opensearch-project/dashboards-reporting.gitThere was a problem hiding this comment.
Thanks for catching this. It was not intentional. Please check #18
|
Changes to my branch are not reflecting here since the repo became public. Created this instead #18 from new fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rupal Mahajan [email protected]
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.