added fix for runAsync query without mds id #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
Yury-Fridlyand,
anirudha and
paulstn
as code owners
Signed-off-by: sumukhswamy <[email protected]>
RyanL1997
reviewed
May 16, 2024
There was a problem hiding this comment.
Hi @sumukhswamy , still seeing some linting issues. Lets fix it before it gets merge.
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
paulstn
approved these changes
May 17, 2024
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
ps48
reviewed
May 21, 2024
Signed-off-by: sumukhswamy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
- Coverage 59.13% 57.47% -1.66%
==========================================
Files 39 40 +1
Lines 1867 1907 +40
Branches 332 345 +13
==========================================
- Hits 1104 1096 -8
- Misses 647 689 +42
- Partials 116 122 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
commented
May 22, 2024
|
|
||
| server.get( | ||
| { | ||
| path: ROUTE_PATH_SPARK_SQL_JOB_QUERY + "/{id}" + "/{dataSourceMDSId}", | ||
| path: ROUTE_PATH_SPARK_SQL_JOB_QUERY + '/{id}' + '/{dataSourceMDSId?}', |
There was a problem hiding this comment.
Main change for this PR, rest are Linter changes
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
ps48
reviewed
May 23, 2024
ps48
approved these changes
May 23, 2024
|
@sumukhswamy Can you please help create an issue to track cypress tests for workbench with observability plugin? we can mock the backend APIs this way it gives us confidence when we make changes. |
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 23, 2024
* added fix for runAsync query without mds id Signed-off-by: sumukhswamy <[email protected]> * linter fix Signed-off-by: sumukhswamy <[email protected]> * fixed linter issue Signed-off-by: sumukhswamy <[email protected]> * fixed linter issue Signed-off-by: sumukhswamy <[email protected]> * added change for linting issue Signed-off-by: sumukhswamy <[email protected]> * linter issues Signed-off-by: sumukhswamy <[email protected]> * linter issues Signed-off-by: sumukhswamy <[email protected]> * linting fix Signed-off-by: sumukhswamy <[email protected]> * more linting issues Signed-off-by: sumukhswamy <[email protected]> * added linting fixes Signed-off-by: sumukhswamy <[email protected]> * refactored flyout code with interface Signed-off-by: sumukhswamy <[email protected]> * added fix for import of interface Signed-off-by: sumukhswamy <[email protected]> * added linter fix Signed-off-by: sumukhswamy <[email protected]> * added linter fix Signed-off-by: sumukhswamy <[email protected]> * added linter fix Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments Signed-off-by: sumukhswamy <[email protected]> * linter fix Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 4ae9a53) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 23, 2024
* added fix for runAsync query without mds id Signed-off-by: sumukhswamy <[email protected]> * linter fix Signed-off-by: sumukhswamy <[email protected]> * fixed linter issue Signed-off-by: sumukhswamy <[email protected]> * fixed linter issue Signed-off-by: sumukhswamy <[email protected]> * added change for linting issue Signed-off-by: sumukhswamy <[email protected]> * linter issues Signed-off-by: sumukhswamy <[email protected]> * linter issues Signed-off-by: sumukhswamy <[email protected]> * linting fix Signed-off-by: sumukhswamy <[email protected]> * more linting issues Signed-off-by: sumukhswamy <[email protected]> * added linting fixes Signed-off-by: sumukhswamy <[email protected]> * refactored flyout code with interface Signed-off-by: sumukhswamy <[email protected]> * added fix for import of interface Signed-off-by: sumukhswamy <[email protected]> * added linter fix Signed-off-by: sumukhswamy <[email protected]> * added linter fix Signed-off-by: sumukhswamy <[email protected]> * added linter fix Signed-off-by: sumukhswamy <[email protected]> * addressed pr comments Signed-off-by: sumukhswamy <[email protected]> * linter fix Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 4ae9a53) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
that referenced
this pull request
May 23, 2024
* added fix for runAsync query without mds id * linter fix * fixed linter issue * fixed linter issue * added change for linting issue * linter issues * linter issues * linting fix * more linting issues * added linting fixes * refactored flyout code with interface * added fix for import of interface * added linter fix * added linter fix * added linter fix * addressed pr comments * linter fix --------- (cherry picked from commit 4ae9a53) Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.