-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates create accelerations flyout usage and side tree #285
Conversation
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 61.47% 59.34% -2.13%
==========================================
Files 33 39 +6
Lines 1599 1835 +236
Branches 284 328 +44
==========================================
+ Hits 983 1089 +106
- Misses 518 633 +115
- Partials 98 113 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
|
||
useEffect(() => { | ||
loadtree(); | ||
}, [selectedItems, refreshTree]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. if selectedItems and refreshTree are required dependencies for loadTree, then it's better to explicitly pass them in since you are declared them in dependency array
Signed-off-by: Shenoy Pratik <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-query-workbench/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-query-workbench/backport-2.x
# Create a new branch
git switch --create backport/backport-285-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d168db7402d077681d895309ebe05a50e8880e72
# Push it to GitHub
git push --set-upstream origin backport/backport-285-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-query-workbench/backport-2.x Then, create a pull request where the |
…roject#285) * init use observability deps Signed-off-by: Shenoy Pratik <[email protected]> * update side tree view Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * update release notes Signed-off-by: Shenoy Pratik <[email protected]> * removes console.log Signed-off-by: Shenoy Pratik <[email protected]> * allow refresh only after first load Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * revert version to 3.0 Signed-off-by: Shenoy Pratik <[email protected]> * on umount stop loading Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit d168db7)
* init use observability deps Signed-off-by: Shenoy Pratik <[email protected]> * update side tree view Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * update release notes Signed-off-by: Shenoy Pratik <[email protected]> * removes console.log Signed-off-by: Shenoy Pratik <[email protected]> * allow refresh only after first load Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * revert version to 3.0 Signed-off-by: Shenoy Pratik <[email protected]> * on umount stop loading Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit d168db7)
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-query-workbench/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/dashboards-query-workbench/backport-2.13
# Create a new branch
git switch --create backport/backport-285-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d168db7402d077681d895309ebe05a50e8880e72
# Push it to GitHub
git push --set-upstream origin backport/backport-285-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-query-workbench/backport-2.13 Then, create a pull request where the |
* init use observability deps Signed-off-by: Shenoy Pratik <[email protected]> * update side tree view Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> * update release notes Signed-off-by: Shenoy Pratik <[email protected]> * removes console.log Signed-off-by: Shenoy Pratik <[email protected]> * allow refresh only after first load Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> * revert version to 3.0 Signed-off-by: Shenoy Pratik <[email protected]> * on umount stop loading Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit d168db7) (cherry picked from commit 754b93e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#288) * init use observability deps * update side tree view * update tests * update release notes * removes console.log * allow refresh only after first load * update snapshots * revert version to 3.0 * on umount stop loading --------- (cherry picked from commit d168db7) (cherry picked from commit 754b93e) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Updates create accelerations flyout usage and side tree
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.