Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added changes for making tree view persistent, made changes for bugs for loading screen #153

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Added changes for making tree view persistent, made changes for bugs for loading screen #153

merged 9 commits into from
Oct 20, 2023

Conversation

sumukhswamy
Copy link
Collaborator

Description

Treeview updates
loading screen updates

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48
ps48 reviewed Oct 12, 2023
View reviewed changes
common/constants/index.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #153 (49e1883) into main (55d6352) will increase coverage by 4.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   54.65%   59.02%   +4.36%     
==========================================
  Files          33       33              
  Lines        1396     1452      +56     
  Branches      224      237      +13     
==========================================
+ Hits          763      857      +94     
- Misses        548      575      +27     
+ Partials       85       20      -65
Flag Coverage Δ
dashboards-query-workbench 59.02% <ø> (+4.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

ps48
ps48 reviewed Oct 12, 2023
View reviewed changes
common/types/index.ts Outdated Show resolved Hide resolved
@ps48
Copy link
Member

ps48 commented Oct 13, 2023

@sumukhswamy code looks much cleaner now. Added some minor comments, can you please add jest tests for this file?

ps48
ps48 reviewed Oct 19, 2023
View reviewed changes
common/types/index.ts Outdated Show resolved Hide resolved
ps48
ps48 reviewed Oct 19, 2023
View reviewed changes
public/components/SQLPage/TableView.tsx Outdated
@@ -4,6 +4,7 @@
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the filename to https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/DEVELOPER_GUIDE.md#filenames. We added this file in 2.11 hence it should adhere to the OSD plugin guidelines.

@sumukhswamy
Copy link
Collaborator Author

part1.1.1.mp4

mengweieric
mengweieric approved these changes Oct 20, 2023
View reviewed changes
common/types/index.ts
export type AsyncQueryLoadingStatus = 'SUCCESS' | 'FAILED' | 'RUNNING' | 'SCHEDULED' | 'CANCELLED';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to consider using enum here? something like

export enum AsyncQueryLoadingStatus {
  SUCCESS = 'SUCCESS',
  FAILED = 'FAILED',
  RUNNING = 'RUNNING',
  SCHEDULED = 'SCHEDULED',
  CANCELLED = 'CANCELLED'
}

export enum TreeItemType {
  COVERING_INDEX = 'covering_index',
  SKIPPING_INDEX = 'skipping_index',
  TABLE = 'table',
  DATABASE = 'database',
  MATERIALIZED_VIEW = 'materialized_view',
  LOAD_MATERIALIZED_VIEW = 'Load Materialized View', // Consider renaming this for consistency
  BADGE = 'badge'
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumukhswamy Can you take this as a fast follow in the next PR?

@ps48 ps48 merged commit 75f9cca into opensearch-project:main Oct 20, 2023
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 20, 2023
@github-actions
Added changes for making tree view persistent, made changes for bugs …
cc8d565 
…for loading screen (#153)

* made the tree persistant, added changes for loading screen

Signed-off-by: sumukhswamy <[email protected]>

* changes for the text displayed during loading screen

Signed-off-by: sumukhswamy <[email protected]>

* addressed pr comments

Signed-off-by: sumukhswamy <[email protected]>

* addressed pr comments, added code for reload button

Signed-off-by: sumukhswamy <[email protected]>

* addressed pr comments, added Materialiazed view badges, bug fixes for loading state

Signed-off-by: sumukhswamy <[email protected]>

* updated snapshots

Signed-off-by: sumukhswamy <[email protected]>

* added tests, addressed pr comments

Signed-off-by: sumukhswamy <[email protected]>

* added fix for text overflowing

Signed-off-by: sumukhswamy <[email protected]>

---------

Signed-off-by: sumukhswamy <[email protected]>
(cherry picked from commit 75f9cca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 20, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 20, 2023
@github-actions
Added changes for making tree view persistent, made changes for bugs …
eb519a6 
…for loading screen (#153)

* made the tree persistant, added changes for loading screen

Signed-off-by: sumukhswamy <[email protected]>

* changes for the text displayed during loading screen

Signed-off-by: sumukhswamy <[email protected]>

* addressed pr comments

Signed-off-by: sumukhswamy <[email protected]>

* addressed pr comments, added code for reload button

Signed-off-by: sumukhswamy <[email protected]>

* addressed pr comments, added Materialiazed view badges, bug fixes for loading state

Signed-off-by: sumukhswamy <[email protected]>

* updated snapshots

Signed-off-by: sumukhswamy <[email protected]>

* added tests, addressed pr comments

Signed-off-by: sumukhswamy <[email protected]>

* added fix for text overflowing

Signed-off-by: sumukhswamy <[email protected]>

---------

Signed-off-by: sumukhswamy <[email protected]>
(cherry picked from commit 75f9cca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 20, 2023
Merged
ps48 pushed a commit that referenced this pull request Oct 20, 2023
@opensearch-trigger-bot @github-actions
Added changes for making tree view persistent, made changes for bugs …
2269d1d 
…for loading screen (#153) (#167)

* made the tree persistant, added changes for loading screen



* changes for the text displayed during loading screen



* addressed pr comments



* addressed pr comments, added code for reload button



* addressed pr comments, added Materialiazed view badges, bug fixes for loading state



* updated snapshots



* added tests, addressed pr comments



* added fix for text overflowing



---------


(cherry picked from commit 75f9cca)

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 20, 2023
@opensearch-trigger-bot @github-actions
Added changes for making tree view persistent, made changes for bugs …
50e2d1a 
…for loading screen (#153) (#166)

* made the tree persistant, added changes for loading screen



* changes for the text displayed during loading screen



* addressed pr comments



* addressed pr comments, added code for reload button



* addressed pr comments, added Materialiazed view badges, bug fixes for loading state



* updated snapshots



* added tests, addressed pr comments



* added fix for text overflowing



---------


(cherry picked from commit 75f9cca)

Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Added changes for making tree view persistent, made changes f…
5d8614c 
…or bugs for loading screen (opensearch-project#153) (opensearch-project#167)"

This reverts commit 2269d1d.
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Added changes for making tree view persistent, made changes f…
2984b70 
…or bugs for loading screen (opensearch-project#153) (opensearch-project#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <[email protected]>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#211)
32a7495 
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)"

This reverts commit 26ed0dc.

Signed-off-by: Eric <[email protected]>

* Revert "Increment version to 2.11.1.0 (#186)"

This reverts commit b18f5f4.

Signed-off-by: Eric <[email protected]>

* Revert "added fix for loading spinner issue for other database (#189) (#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <[email protected]>

* Revert "UI-bug fixes, added create query for MV (#182) (#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <[email protected]>

* Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)"

This reverts commit f96c5d9.

Signed-off-by: Eric <[email protected]>

* Revert "Session update, minor fixes for acceleration flyout (#179) (#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <[email protected]>

* Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)"

This reverts commit 3c47d47.

Signed-off-by: Eric <[email protected]>

* Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <[email protected]>

* Revert "design changes for loading, changed the banner, updated tests (#170) (#172)"

This reverts commit 786c7c7.

Signed-off-by: Eric <[email protected]>

* Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <[email protected]>

* Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <[email protected]>

* Revert "fixed create table async query bug (#158) (#163)"

This reverts commit 1964008.

Signed-off-by: Eric <[email protected]>

---------

Signed-off-by: Eric <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@mengweieric mengweieric mengweieric approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vmmusings vmmusings Awaiting requested review from vmmusings

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumukhswamy @ps48 @mengweieric