Bug fixes for SQL UI buttons #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
requested review from
pjfitzgibbons,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 54.79% 54.72% -0.07%
==========================================
Files 33 33
Lines 1356 1365 +9
Branches 210 216 +6
==========================================
+ Hits 743 747 +4
- Misses 535 537 +2
- Partials 78 81 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
approved these changes
Oct 5, 2023
| @@ -78,7 +78,7 @@ export const ACCELERATION_INDEX_NAME_INFO = `All OpenSearch acceleration indices | |||
| - 'Materialized View' indices also enable users to define their index name, but they do not have a suffix. | |||
| - An example of a 'Materialized View' index name might look like: \`flint_mydatasource_mydb_mytable_myindexname\`. | |||
| ##### Note: | |||
| - All user given index names must be in lowercase letters. Cannot begin with underscores or hyphens. Spaces, commas, and characters :, ", *, +, /, \, |, ?, #, >, or < are not allowed. | |||
| - All user given index names must be in lowercase letters. Index name cannot begin with underscores. Spaces, commas, and characters -, :, ", *, +, /, \, |, ?, #, >, or < are not allowed. | |||
There was a problem hiding this comment.
i think i asked this somewhere else but if
All user given index names must be in lowercase letters
and -, :, ", *, +, /, \, |, ?, #, >, or < are obviously not lowercase letters, why does it mention those characters are not allowed?
There was a problem hiding this comment.
This is taken from here: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/indexing.html
Docs team didn't get time for a review.
kavithacm
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* adding paper cuts Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit c819cd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* adding paper cuts Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit c819cd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Oct 5, 2023
* adding paper cuts * update snapshots --------- (cherry picked from commit c819cd4) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Oct 5, 2023
* adding paper cuts * update snapshots --------- (cherry picked from commit c819cd4) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding bug fixes for SQL UI buttons
Issues Resolved
#122
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.