Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new changes for the sidebar #124

Closed
wants to merge 2 commits into from
Closed

added new changes for the sidebar #124

wants to merge 2 commits into from

Conversation

sumukhswamy
Copy link
Collaborator

Description

added data connections tab in the sidebar

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: sumukhswamy <[email protected]>
Comment on lines 686 to 691
// const [isClearable, setIsClearable] = useState(true);

// const [value, setValue] = useState('');
// const onChange = (e) => {
// setValue(e.target.value);
// };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the commented code

import { IHttpResponse } from 'angular';
import _ from 'lodash';
import React from 'react';
import React, { useState } from 'react';
Copy link
Member

@ps48 ps48 Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useState , EuiPageTemplate are unused headers can you please remove them?

Copy link
Member

@ps48 ps48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to update the snapshot of jest tests when you're changing these files.

@ps48 ps48 changed the base branch from main to feature/flint-ui September 18, 2023 17:28
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #124 (1f28351) into feature/flint-ui (69a91fb) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 1f28351 differs from pull request most recent head dffcdc6. Consider uploading reports for the commit dffcdc6 to get more accurate results

@@                 Coverage Diff                  @@
##           feature/flint-ui     #124      +/-   ##
====================================================
+ Coverage             62.76%   62.82%   +0.05%     
====================================================
  Files                    10       10              
  Lines                   658      659       +1     
  Branches                119      119              
====================================================
+ Hits                    413      414       +1     
  Misses                  192      192              
  Partials                 53       53              
Flag Coverage Δ
dashboards-query-workbench 62.82% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { EuiButton, EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle } from '@elastic/eui';
import { EuiButton, EuiFlexGroup, EuiFlexItem, EuiSpacer, EuiTitle, EuiPageSideBar ,EuiSideNav, EuiPanel, EuiPageTemplate, EuiPage, EuiPageContent, EuiPageContentBody, EuiFlexGrid, EuiSplitPanel, EuiComboBox, EuiText, EuiPagination, EuiPopover, EuiFieldSearch} from '@elastic/eui';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run lint here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants