Skip to content

Commit

Permalink
added a few changes for comments
Browse files Browse the repository at this point in the history
Signed-off-by: sumukhswamy <[email protected]>
  • Loading branch information
sumukhswamy committed Feb 1, 2024
1 parent 8a6ee40 commit 06778fc
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
4 changes: 2 additions & 2 deletions public/components/PPLPage/PPLPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export class PPLPage extends React.Component<PPLPageProps, PPLPageState> {
>
<EuiButton
fill={true}
data-test-subj='pplRunButton'
data-test-subj="pplRunButton"
className="sql-editor-button"
isLoading={this.props.asyncLoading}
onClick={() => this.props.onRun(this.props.pplQuery)}
Expand All @@ -146,7 +146,7 @@ export class PPLPage extends React.Component<PPLPageProps, PPLPageState> {
this.props.onClear();
}}
>
<EuiButton className="sql-editor-button" data-test-subj='pplClearButton' isDisabled={this.props.asyncLoading}>
<EuiButton className="sql-editor-button" data-test-subj="pplClearButton" isDisabled={this.props.asyncLoading}>
Clear
</EuiButton>
</EuiFlexItem>
Expand Down
4 changes: 1 addition & 3 deletions public/components/QueryLanguageSwitch/Switch.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,9 @@
* SPDX-License-Identifier: Apache-2.0
*/

import React from 'react';
import _ from 'lodash';
import { EuiButtonGroup } from '@elastic/eui';
import React from 'react';
// @ts-ignore
import { htmlIdGenerator } from '@elastic/eui/lib/services';

interface SwitchProps {
onChange: (id: string, value?: any) => void;
Expand Down
2 changes: 1 addition & 1 deletion public/components/QueryResults/QueryResults.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ class QueryResults extends React.Component<QueryResultsProps, QueryResultsState>
id="tabsContainer"
>
<EuiFlexItem style={{ marginTop: '8px' }} grow={false}>
<EuiTabs data-test-subj = "result_tab" style={{ marginLeft: 7, marginBottom: 6 }}>{tabsButtons}</EuiTabs>
<EuiTabs data-test-subj="result_tab" style={{ marginLeft: 7, marginBottom: 6 }}>{tabsButtons}</EuiTabs>
</EuiFlexItem>
</EuiFlexGroup>

Expand Down
4 changes: 2 additions & 2 deletions public/components/SQLPage/SQLPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export class SQLPage extends React.Component<SQLPageProps, SQLPageState> {
<EuiFlexGroup className="action-container" gutterSize="m">
<EuiFlexItem grow={false} >
<EuiButton
data-test-subj='sqlRunButton'
data-test-subj="sqlRunButton"
fill={true}
className="sql-editor-button"
isLoading={this.props.asyncLoading}
Expand All @@ -185,7 +185,7 @@ export class SQLPage extends React.Component<SQLPageProps, SQLPageState> {
this.props.onClear();
}}
>
<EuiButton data-test-subj='sqlClearButton' className="sql-editor-button" isDisabled={this.props.asyncLoading}>
<EuiButton data-test-subj="sqlClearButton" className="sql-editor-button" isDisabled={this.props.asyncLoading}>
Clear
</EuiButton>
</EuiFlexItem>
Expand Down

0 comments on commit 06778fc

Please sign in to comment.