Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files #650

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

mengweieric
Copy link
Collaborator

Description

Remove leftover icons and update snapshots.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #650 (ae0c03e) into 1.3 (63cf078) will decrease coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.3     #650      +/-   ##
==========================================
- Coverage   46.42%   45.97%   -0.45%     
==========================================
  Files         201      192       -9     
  Lines        5577     5457     -120     
  Branches     1357     1279      -78     
==========================================
- Hits         2589     2509      -80     
+ Misses       2955     2921      -34     
+ Partials       33       27       -6     
Flag Coverage Δ
dashboards-observability 45.97% <ø> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

@mengweieric mengweieric merged commit 2818128 into opensearch-project:1.3 Jul 12, 2023
@mengweieric mengweieric deleted the update-viz branch July 12, 2023 23:03
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2023
* remove unused files

Signed-off-by: Eric Wei <[email protected]>

* added one updated snapshots after rebasing

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 2818128)
mengweieric added a commit that referenced this pull request Jul 13, 2023
* remove unused files

Signed-off-by: Eric Wei <[email protected]>

* added one updated snapshots after rebasing

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 2818128)

Co-authored-by: Eric Wei <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport/backport-650-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 28181285a8eee463afa63b57eb7e7c935ecf822b
# Push it to GitHub
git push --set-upstream origin backport/backport-650-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport/backport-650-to-1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants