Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT 2.5] cypress test fixes for jaeger #279

Merged

Conversation

derek-ho
Copy link
Collaborator

fix up cypress and add jaeger tests (#265)

  • fix up cypress and add jaeger tests

  • fix snapshot tests

  • fix services cypress file and add jaeger tests

  • fix trace cypress and jaeger for traces


(cherry picked from commit 7daf880)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

fix up cypress and add jaeger tests (opensearch-project#265)

* fix up cypress and add jaeger tests

Signed-off-by: Derek Ho <[email protected]>

* fix snapshot tests

Signed-off-by: Derek Ho <[email protected]>

* fix services cypress file and add jaeger tests

Signed-off-by: Derek Ho <[email protected]>

* fix trace cypress and jaeger for traces

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 7daf880)
Signed-off-by: Derek Ho <[email protected]>
@derek-ho derek-ho changed the title merge fixes [BACKPORT 2.5] cypress test fixes for jaeger Feb 14, 2023
@mengweieric
Copy link
Collaborator

Do we need to update FTR repo once these done?

@derek-ho derek-ho marked this pull request as ready for review February 20, 2023 20:14
@derek-ho derek-ho requested a review from a team as a code owner February 20, 2023 20:14
@derek-ho
Copy link
Collaborator Author

Do we need to update FTR repo once these done?

This is needed to fix a test in the FTR, but yes there are other tests that we removed that should be added back once this fix goes in

@derek-ho derek-ho merged commit 5e23c98 into opensearch-project:2.5 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants