Add compile step before Cypress runs in CI #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
force-pushed
the
fix-ci
branch
3 times, most recently
from
27ba559 to
22b1613
Compare
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
3 tasks
ps48
approved these changes
Oct 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Add compile step before run step Signed-off-by: Simeon Widdis <[email protected]> * Remove wait-for-startup step Signed-off-by: Simeon Widdis <[email protected]> * Fix detection of server startup Signed-off-by: Simeon Widdis <[email protected]> * Fix cache finding no lock files Signed-off-by: Simeon Widdis <[email protected]> * Add caches for different package targets Signed-off-by: Simeon Widdis <[email protected]> * Fix caches Signed-off-by: Simeon Widdis <[email protected]> * Add yarn cache to regular unit tests Signed-off-by: Simeon Widdis <[email protected]> * Remove target cache in ftr Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> (cherry picked from commit fb9027a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
reviewed
Oct 8, 2024
| exit 1 | ||
| fi | ||
| fi& |
There was a problem hiding this comment.
if you put to background it will continue to next step even if http server running didn't appear in dashboard.log yet, right? and if 60 seconds passed, will exit 1 be able to abort the workflow if it has already moved to the next step?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current cypress runs are failing with the error
Timeout for 600 seconds reached. OpenSearch Dashboards did not finish compiling.. By far, the longest step of OSD startup is compilation. A little poking around upstream reveals that there's a script that can frontload this compilation, so we can separate the server startup from the compile step. This PR applies this, and lowers the timeout since it no longer needs to be so high. It also adds some caching to reduce build times, although there's a bit more that needs to happen to make build times fast (namely, caching all the /target folders, see #2188).Issues Resolved
See above
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.