[Bug] UI changes for overview page, fix re-direction for workspaces #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
ps48
reviewed
Sep 10, 2024
| @@ -18,6 +18,7 @@ import { | |||
| } from '@elastic/eui'; | |||
| import { coreRefs } from '../../../../public/framework/core_refs'; | |||
| import { fetchDashboardIds, fetchIndexPatternIds, redirectToDashboards } from './utils'; | |||
| import { getWorkspaceIdFromUrl } from '../../../../../../src/core/public/utils/index'; | |||
There was a problem hiding this comment.
Nit. Can use import { getWorkspaceIdFromUrl } from '../../../../../../src/core/public'
There was a problem hiding this comment.
adjusted too:
import { getWorkspaceIdFromUrl } from '../../../../../../src/core/public/utils';
Couldn't use just public without error
ps48
reviewed
Sep 10, 2024
Signed-off-by: Adam Tackett <[email protected]>
joshuali925
approved these changes
Sep 10, 2024
public/components/getting_started/components/getting_started_collectData.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Tackett <[email protected]>
joshuali925
reviewed
Sep 10, 2024
public/components/getting_started/components/getting_started.tsx
Outdated
Show resolved
Hide resolved
public/components/getting_started/components/getting_started_collectData.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Tackett <[email protected]>
|
Updates to Getting started text and ui After: |
Signed-off-by: Adam Tackett <[email protected]>
ps48
approved these changes
Sep 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…2152) * update overview page, redirection bug, change text Signed-off-by: Adam Tackett <[email protected]> * change card order, make button small, rename variable Signed-off-by: Adam Tackett <[email protected]> * fix bugs, adjust ui Signed-off-by: Adam Tackett <[email protected]> * address comments Signed-off-by: Adam Tackett <[email protected]> * change text Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit ce419d8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
…2152) * update overview page, redirection bug, change text Signed-off-by: Adam Tackett <[email protected]> * change card order, make button small, rename variable Signed-off-by: Adam Tackett <[email protected]> * fix bugs, adjust ui Signed-off-by: Adam Tackett <[email protected]> * address comments Signed-off-by: Adam Tackett <[email protected]> * change text Signed-off-by: Adam Tackett <[email protected]> --------- Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit ce419d8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now lands on page with correct UI
Screen.Recording.2024-09-10.at.4.35.20.PM.mov
Added Try OpenSearch card that directs user to add sample data, updated footer of cards.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.