Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace Analytics support for custom sources #2112

Merged
merged 11 commits into from
Sep 4, 2024

remove console.log, update copy and tests

850a8c8
Select commit
Loading
Failed to load commit list.
Merged

Trace Analytics support for custom sources #2112

remove console.log, update copy and tests
850a8c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 4, 2024 in 0s

56.59% (-1.26%) compared to c3ab50f

View this Pull Request on Codecov

56.59% (-1.26%) compared to c3ab50f

Details

Codecov Report

Attention: Patch coverage is 36.18234% with 224 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (c3ab50f) to head (850a8c8).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
.../components/traces/traces_custom_indices_table.tsx 0.00% 69 Missing ⚠️
...trace_analytics/requests/traces_request_handler.ts 15.38% 33 Missing ⚠️
...ace_analytics/components/traces/traces_content.tsx 45.23% 22 Missing and 1 partial ⚠️
...race_analytics/components/traces/services_list.tsx 4.76% 20 Missing ⚠️
...nalytics/components/common/custom_index_flyout.tsx 46.87% 17 Missing ⚠️
...e_analytics/components/common/helper_functions.tsx 66.66% 10 Missing ⚠️
...trace_analytics/requests/queries/traces_queries.ts 41.17% 10 Missing ⚠️
..._analytics/components/common/plots/service_map.tsx 50.00% 8 Missing ⚠️
...ace_analytics/components/services/service_view.tsx 33.33% 8 Missing ⚠️
...analytics/components/traces/span_detail_flyout.tsx 42.85% 7 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   57.85%   56.59%   -1.26%     
==========================================
  Files         372      389      +17     
  Lines       14081    14938     +857     
  Branches     3712     4049     +337     
==========================================
+ Hits         8146     8454     +308     
- Misses       5871     6422     +551     
+ Partials       64       62       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.