Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Logs UI update #2092

Merged
merged 8 commits into from
Aug 27, 2024
Merged

[Feature] Logs UI update #2092

merged 8 commits into from
Aug 27, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Aug 23, 2024

Description

  1. Update the UI to conform with header changes.

Logs Before:
Screenshot 2024-08-23 at 9 39 17 AM

Screenshot 2024-08-23 at 9 38 53 AM

After:
Screenshot 2024-08-23 at 9 36 30 AM

Screenshot 2024-08-23 at 9 36 57 AM

Remade Type filter working:
Screenshot 2024-08-23 at 9 40 10 AM

PPL button adjustment:
Screenshot 2024-08-23 at 10 50 02 AM

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TackAdam TackAdam changed the title [Feature] Logs UI update [Feature] Logs UI update and bugfix Aug 26, 2024
@TackAdam TackAdam changed the title [Feature] Logs UI update and bugfix [Feature] Logs UI update Aug 26, 2024
@TackAdam TackAdam added enhancement New feature or request backport 2.x labels Aug 26, 2024
@TackAdam TackAdam marked this pull request as ready for review August 26, 2024 18:47
Copy link
Collaborator

@paulstn paulstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are some test failures, one of which I looked at failed due to a required parameter not being provided

Signed-off-by: Adam Tackett <[email protected]>
@TackAdam
Copy link
Collaborator Author

It seems like there are some test failures, one of which I looked at failed due to a required parameter not being provided

CI's all passing. Checked manually for cypress changes for creating visualizations in explorer. All working correctly

Copy link
Collaborator

@paulstn paulstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Adam!

@TackAdam TackAdam merged commit a9c3ea1 into opensearch-project:main Aug 27, 2024
11 of 18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 27, 2024
* Ui updates to logs

Signed-off-by: Adam Tackett <[email protected]>

* update test and snapshot

Signed-off-by: Adam Tackett <[email protected]>

* remove actions popover

Signed-off-by: Adam Tackett <[email protected]>

---------

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
(cherry picked from commit a9c3ea1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Aug 27, 2024
* Ui updates to logs



* update test and snapshot



* remove actions popover



---------



(cherry picked from commit a9c3ea1)

Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tackett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants